Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 356853004: Remove StyleResolver::ensureScopedStyleResolver (Closed)

Created:
6 years, 6 months ago by esprehn
Modified:
6 years, 5 months ago
Reviewers:
dglazkov, kochi, eseidel
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove StyleResolver::ensureScopedStyleResolver This makes the callers less awkward, and also removes this API from the public interface of StyleResolver which is out of hand. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
6 years, 6 months ago (2014-06-26 03:14:38 UTC) #1
kochi
lgtm
6 years, 6 months ago (2014-06-26 04:24:02 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 6 months ago (2014-06-26 04:34:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/356853004/1
6 years, 6 months ago (2014-06-26 04:35:27 UTC) #4
esprehn
The CQ bit was unchecked by esprehn@chromium.org
6 years, 6 months ago (2014-06-26 23:53:22 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 6 months ago (2014-06-26 23:53:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/356853004/1
6 years, 6 months ago (2014-06-26 23:53:35 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 01:29:28 UTC) #8
Message was sent while issue was closed.
Change committed as 177037

Powered by Google App Engine
This is Rietveld 408576698