Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 356853003: Share more code between boundingBoxForCompositing and physicalBoundingBoxIncludingRASC (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Share more code between boundingBoxForCompositing and physicalBoundingBoxIncludingReflectionAndStackingChildren This also makes it easier to see what the code is computing. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177031

Patch Set 1 #

Patch Set 2 : More simplify. #

Patch Set 3 : Fixed. #

Patch Set 4 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -36 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 2 3 3 chunks +21 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chrishtr
6 years, 6 months ago (2014-06-26 02:35:45 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-26 06:52:11 UTC) #2
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-26 16:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/356853003/60001
6 years, 6 months ago (2014-06-26 16:41:22 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 00:51:04 UTC) #5
Message was sent while issue was closed.
Change committed as 177031

Powered by Google App Engine
This is Rietveld 408576698