Fix private member access violations in profiler module

Source/devtools/front_end/profiler/heap_snapshot_worker/JSHeapSnapshot.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 79 matching lines @@
         if (!mapAndFlag)
             return null;
         var map = mapAndFlag.map;
         var flag = mapAndFlag.flag;
         /**
          * @param {!WebInspector.JSHeapSnapshotNode} node
          * @return {boolean}
          */
         function filter(node)
         {
-            return !!(map[node._ordinal()] & flag);
+            return !!(map[node.ordinal()] & flag);
         }
         return filter;
     },
 
     /**
      * @return {function(!WebInspector.HeapSnapshotEdge):boolean}
      */
     containmentEdgesFilter: function()
     {
         var showHiddenData = this._showHiddenData;
@@ skipping 58 matching lines @@
             }
             return null;
         }
 
         var visitedNodes = {};
         /**
          * @param {!WebInspector.HeapSnapshotNode} node
          */
         function doAction(node)
         {
-            var ordinal = node._ordinal();
+            var ordinal = node.ordinal();
             if (!visitedNodes[ordinal]) {
                 action(node);
                 visitedNodes[ordinal] = true;
             }
         }
 
         var gcRoots = getChildNodeByName(this.rootNode(), "(GC roots)");
         if (!gcRoots)
             return;
 
@@ skipping 62 matching lines @@
         // via regular properties, and for DOM wrappers. Trying to access random objects
         // can cause a crash due to insonsistent state of internal properties of wrappers.
         var flag = this._nodeFlags.canBeQueried;
         var hiddenEdgeType = this._edgeHiddenType;
         var internalEdgeType = this._edgeInternalType;
         var invisibleEdgeType = this._edgeInvisibleType;
         var weakEdgeType = this._edgeWeakType;
         var edgeToNodeOffset = this._edgeToNodeOffset;
         var edgeTypeOffset = this._edgeTypeOffset;
         var edgeFieldsCount = this._edgeFieldsCount;
-        var containmentEdges = this._containmentEdges;
-        var nodes = this._nodes;
+        var containmentEdges = this.containmentEdges;
+        var nodes = this.nodes;
         var nodeCount = this.nodeCount;
         var nodeFieldCount = this._nodeFieldCount;
         var firstEdgeIndexes = this._firstEdgeIndexes;
 
         var flags = this._flags;
         var list = [];
 
         for (var iter = this.rootNode().edges(); iter.hasNext(); iter.next()) {
             if (iter.edge.node().isUserRoot())
                 list.push(iter.edge.node().nodeIndex / nodeFieldCount);
@@ skipping 21 matching lines @@
 
     _markPageOwnedNodes: function()
     {
         var edgeShortcutType = this._edgeShortcutType;
         var edgeElementType = this._edgeElementType;
         var edgeToNodeOffset = this._edgeToNodeOffset;
         var edgeTypeOffset = this._edgeTypeOffset;
         var edgeFieldsCount = this._edgeFieldsCount;
         var edgeWeakType = this._edgeWeakType;
         var firstEdgeIndexes = this._firstEdgeIndexes;
-        var containmentEdges = this._containmentEdges;
+        var containmentEdges = this.containmentEdges;
         var containmentEdgesLength = containmentEdges.length;
-        var nodes = this._nodes;
+        var nodes = this.nodes;
         var nodeFieldCount = this._nodeFieldCount;
         var nodesCount = this.nodeCount;
 
         var flags = this._flags;
         var flag = this._nodeFlags.pageObject;
         var visitedMarker = this._nodeFlags.visitedMarker;
         var visitedMarkerMask = this._nodeFlags.visitedMarkerMask;
         var markerAndFlag = visitedMarker | flag;
 
         var nodesToVisit = new Uint32Array(nodesCount);
@@ skipping 33 matching lines @@
                     continue;
                 nodesToVisit[nodesToVisitLength++] = childNodeOrdinal;
                 flags[childNodeOrdinal] |= visitedMarker;
             }
         }
     },
 
     _calculateStatistics: function()
     {
         var nodeFieldCount = this._nodeFieldCount;
-        var nodes = this._nodes;
+        var nodes = this.nodes;
         var nodesLength = nodes.length;
         var nodeTypeOffset = this._nodeTypeOffset;
         var nodeSizeOffset = this._nodeSelfSizeOffset;;
         var nodeNativeType = this._nodeNativeType;
         var nodeCodeType = this._nodeCodeType;
         var nodeConsStringType = this._nodeConsStringType;
         var nodeSlicedStringType = this._nodeSlicedStringType;
         var sizeNative = 0;
         var sizeCode = 0;
         var sizeStrings = 0;
@@ skipping 21 matching lines @@
         this._statistics.strings = sizeStrings;
     },
 
     /**
      * @param {!WebInspector.HeapSnapshotNode} node
      * @return {number}
      */
     _calculateArraySize: function(node)
     {
         var size = node.selfSize();
-        var beginEdgeIndex = node._edgeIndexesStart();
-        var endEdgeIndex = node._edgeIndexesEnd();
-        var containmentEdges = this._containmentEdges;
-        var strings = this._strings;
+        var beginEdgeIndex = node.edgeIndexesStart();
+        var endEdgeIndex = node.edgeIndexesEnd();
+        var containmentEdges = this.containmentEdges;
+        var strings = this.strings;
         var edgeToNodeOffset = this._edgeToNodeOffset;
         var edgeTypeOffset = this._edgeTypeOffset;
         var edgeNameOffset = this._edgeNameOffset;
         var edgeFieldsCount = this._edgeFieldsCount;
         var edgeInternalType = this._edgeInternalType;
         for (var edgeIndex = beginEdgeIndex; edgeIndex < endEdgeIndex; edgeIndex += edgeFieldsCount) {
             var edgeType = containmentEdges[edgeIndex + edgeTypeOffset];
             if (edgeType !== edgeInternalType)
                 continue;
             var edgeName = strings[containmentEdges[edgeIndex + edgeNameOffset]];
@@ skipping 59 matching lines @@
 
     _consStringName: function()
     {
         var snapshot = this._snapshot;
         var consStringType = snapshot._nodeConsStringType;
         var edgeInternalType = snapshot._edgeInternalType;
         var edgeFieldsCount = snapshot._edgeFieldsCount;
         var edgeToNodeOffset = snapshot._edgeToNodeOffset;
         var edgeTypeOffset = snapshot._edgeTypeOffset;
         var edgeNameOffset = snapshot._edgeNameOffset;
-        var strings = snapshot._strings;
-        var edges = snapshot._containmentEdges;
+        var strings = snapshot.strings;
+        var edges = snapshot.containmentEdges;
         var firstEdgeIndexes = snapshot._firstEdgeIndexes;
         var nodeFieldCount = snapshot._nodeFieldCount;
         var nodeTypeOffset = snapshot._nodeTypeOffset;
         var nodeNameOffset = snapshot._nodeNameOffset;
-        var nodes = snapshot._nodes;
+        var nodes = snapshot.nodes;
         var nodesStack = [];
         nodesStack.push(this.nodeIndex);
         var name = "";
 
         while (nodesStack.length && name.length < 1024) {
             var nodeIndex = nodesStack.pop();
             if (nodes[nodeIndex + nodeTypeOffset] !== consStringType) {
                 name += strings[nodes[nodeIndex + nodeNameOffset]];
                 continue;
             }
@@ skipping 36 matching lines @@
             return "(" + type + ")";
         }
     },
 
     /**
      * @return {number}
      */
     classIndex: function()
     {
         var snapshot = this._snapshot;
-        var nodes = snapshot._nodes;
+        var nodes = snapshot.nodes;
         var type = nodes[this.nodeIndex + snapshot._nodeTypeOffset];;
         if (type === snapshot._nodeObjectType || type === snapshot._nodeNativeType)
             return nodes[this.nodeIndex + snapshot._nodeNameOffset];
         return -1 - type;
     },
 
     /**
      * @return {number}
      */
     id: function()
     {
         var snapshot = this._snapshot;
-        return snapshot._nodes[this.nodeIndex + snapshot._nodeIdOffset];
+        return snapshot.nodes[this.nodeIndex + snapshot._nodeIdOffset];
     },
 
     /**
      * @return {boolean}
      */
     isHidden: function()
     {
         return this._type() === this._snapshot._nodeHiddenType;
     },
 
@@ skipping 153 matching lines @@
         return "?" + name + "?";
     },
 
     _hasStringName: function()
     {
         return !this.isElement() && !this.isHidden();
     },
 
     _name: function()
     {
-        return this._hasStringName() ? this._snapshot._strings[this._nameOrIndex()] : this._nameOrIndex();
+        return this._hasStringName() ? this._snapshot.strings[this._nameOrIndex()] : this._nameOrIndex();
     },
 
     _nameOrIndex: function()
     {
         return this._edges[this.edgeIndex + this._snapshot._edgeNameOffset];
     },
 
     _type: function()
     {
         return this._edges[this.edgeIndex + this._snapshot._edgeTypeOffset];
@@ skipping 60 matching lines @@
      * @return {boolean}
      */
     isWeak: function()
     {
         return this._edge().isWeak();
     },
 
     __proto__: WebInspector.HeapSnapshotRetainerEdge.prototype
 }