Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 356843008: Fix private member access violations in profiler module (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
apavlov, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix private member access violations in profiler module BUG=386973 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177107

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed unsupported @protected #

Patch Set 3 : Addressed apavlov's comments #

Messages

Total messages: 7 (0 generated)
yurys
6 years, 5 months ago (2014-06-27 13:20:28 UTC) #1
apavlov
lgtm https://codereview.chromium.org/356843008/diff/1/Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js File Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js (right): https://codereview.chromium.org/356843008/diff/1/Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js#newcode161 Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js:161: // but the actual statistics from the "root" ...
6 years, 5 months ago (2014-06-27 13:27:02 UTC) #2
yurys
https://codereview.chromium.org/356843008/diff/1/Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js File Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js (right): https://codereview.chromium.org/356843008/diff/1/Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js#newcode161 Source/devtools/front_end/profiler/CPUProfileBottomUpDataGrid.js:161: // but the actual statistics from the "root" node ...
6 years, 5 months ago (2014-06-27 13:37:00 UTC) #3
alph
lgtm
6 years, 5 months ago (2014-06-27 13:37:00 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-06-27 13:37:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/356843008/40001
6 years, 5 months ago (2014-06-27 13:37:29 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 14:46:01 UTC) #7
Message was sent while issue was closed.
Change committed as 177107

Powered by Google App Engine
This is Rietveld 408576698