Issue 356843005: Unbreak "os" stuff in shared d8 builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356843005: Unbreak "os" stuff in shared d8 builds. (Closed)

Created:
6 years, 5 months ago by Sven Panne

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Unbreak "os" stuff in shared d8 builds. Note that "os" still has no properties on Windows, but at least it's there. BUG=v8:3407 LOG=y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22058

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -20 lines)			Patch
M	src/d8.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/d8.gyp	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/d8-posix.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/d8-windows.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM Though I can see the next complaint coming: "d8's OS features don't work on ...

6 years, 5 months ago (2014-06-27 09:52:14 UTC) #2

Sven Panne

6 years, 5 months ago (2014-06-27 10:37:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22058 (presubmit successful).