Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issue 356843002: [Android] Disable connect type check for unit test. (Closed)

Created:
6 years, 6 months ago by Feng Qian
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Android] Disable connect type check for unit test. When running safe browsing unit tests, Android devices may not have WiFi connection so some tests may fail because the auto update was not scheduled on non-WiFi network. The CL adds an option to skip the connection type check and the option is only used by unit tests. BUG=381896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279917

Patch Set 1 #

Total comments: 1

Patch Set 2 : adjust the order of debugging fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M chrome/browser/safe_browsing/protocol_manager.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_helper.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Feng Qian
6 years, 6 months ago (2014-06-25 21:12:10 UTC) #1
Scott Hess - ex-Googler
lgtm https://codereview.chromium.org/356843002/diff/1/chrome/browser/safe_browsing/protocol_manager.h File chrome/browser/safe_browsing/protocol_manager.h (right): https://codereview.chromium.org/356843002/diff/1/chrome/browser/safe_browsing/protocol_manager.h#newcode397 chrome/browser/safe_browsing/protocol_manager.h:397: Could you pull this and the disable_auto_update_ case ...
6 years, 6 months ago (2014-06-25 21:34:33 UTC) #2
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-25 21:42:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/356843002/20001
6 years, 6 months ago (2014-06-25 21:43:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 00:56:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 02:33:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/32270)
6 years, 6 months ago (2014-06-26 02:33:45 UTC) #7
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-26 03:59:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/356843002/20001
6 years, 6 months ago (2014-06-26 04:01:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 05:59:51 UTC) #10
Message was sent while issue was closed.
Change committed as 279917

Powered by Google App Engine
This is Rietveld 408576698