Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 356833010: Delete all_page_actions, which is now empty. (Closed)

Created:
6 years, 5 months ago by chrishenry
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, telemetry+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Delete all_page_actions, which is now empty. All existing actions can now be accessed from ActionRunner directly, so this file has outlived its usefulness. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282462

Patch Set 1 : #

Patch Set 2 : Delete pylint comment as well. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -176 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/memory_tests.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/maps.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/alexa1-10000.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/browser_control.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/browser_control_click.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/bypass.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/fallback_viaheader.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/safebrowsing.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/smoke.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/synthetic.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/chrome_proxy/top_20.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/five_blank_pages.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_threadlist_conversation.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_compose_discard.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_expand_collapse_conversation.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/gmail_refresh.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/image_decoding_measurement.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/indexeddb_offline.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_ar_fa_he.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_es_fr_pt-BR.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_hi_ru.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_ja_zh.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_ko_th_vi.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_desktop_sites.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_search_mobile.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/maps.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/media_cns_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/mobile_memory.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/mse_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/alexa_us.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/bloat.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dhtml.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/dom.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/intl1.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/intl2.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejs.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejsnp.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz2.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/pica.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/plus_alt_posts_photos.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/service_worker.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/startup_pages.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/startup_pages_record.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_10.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_10_mobile.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_25.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_desktop_sites_2012Q3.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_dom_memory_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_image_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_layer_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_layout_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_memory_multi_tab.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_pepper_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_scrolling_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_texture_upload_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/typical_25.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/all_page_actions.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest_base.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
chrishenry
6 years, 5 months ago (2014-06-27 18:57:24 UTC) #1
chrishenry
6 years, 5 months ago (2014-06-27 18:58:01 UTC) #2
dtu
Brilliant! lgtm
6 years, 5 months ago (2014-06-27 19:42:29 UTC) #3
Ken Russell (switch to Gerrit)
Nice cleanup. LGTM
6 years, 5 months ago (2014-06-27 20:47:09 UTC) #4
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-06-27 21:35:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/356833010/60001
6 years, 5 months ago (2014-06-27 21:37:53 UTC) #6
chrishenry
The CQ bit was unchecked by chrishenry@google.com
6 years, 5 months ago (2014-06-27 23:22:14 UTC) #7
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-10 20:26:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/356833010/80001
6 years, 5 months ago (2014-07-10 20:27:52 UTC) #9
commit-bot: I haz the power
Change committed as 282462
6 years, 5 months ago (2014-07-10 23:33:02 UTC) #10
aberent
6 years, 4 months ago (2014-08-05 14:19:10 UTC) #11
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/445533004/ by aberent@chromium.org.

The reason for reverting is: Internal tests broken since all_page_actions is
referenced by tools/perf/internal/gwshack/lego_transition.py

BUG=400737.

Powered by Google App Engine
This is Rietveld 408576698