Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: content/shell/app/webkit_test_platform_support_linux.cc

Issue 356733003: Enable layout testing support for font fallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Referencing fonts from Blink's LayoutTests/third_party dir with license info, formatting Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/app/webkit_test_platform_support_linux.cc
diff --git a/content/shell/app/webkit_test_platform_support_linux.cc b/content/shell/app/webkit_test_platform_support_linux.cc
index 3b04631ff62dac43eb14c1cbb66e59f7ec462f91..fd5925766991cb3bf2c73e50aa8fc7104bedef5f 100644
--- a/content/shell/app/webkit_test_platform_support_linux.cc
+++ b/content/shell/app/webkit_test_platform_support_linux.cc
@@ -38,6 +38,25 @@ bool CheckAndLoadFontFile(
return true;
}
+static bool LoadFontResources(const base::FilePath& base_path,
+ FcConfig* font_config) {
+ const char* const own_fonts[] = {"AHEM____.TTF", "GardinerModBug.ttf",
+ "GardinerModCat.ttf"};
+
+ for (size_t i = 0; i < arraysize(own_fonts); ++i) {
+ base::FilePath font_path = base_path.Append(own_fonts[i]);
+ if (access(font_path.value().c_str(), R_OK) < 0 ||
+ !FcConfigAppFontAddFile(
+ font_config,
+ reinterpret_cast<const FcChar8*>(font_path.value().c_str()))) {
+ std::cerr << "Failed to load test font resource "
jamesr 2014/06/26 20:32:29 why doesn't this use base's loggig facilities? i s
+ << font_path.value().c_str() << ".\n";
+ return false;
+ }
+ }
+ return true;
+}
+
const char* const kFonts[] = {
"/usr/share/fonts/truetype/kochi/kochi-gothic.ttf",
"/usr/share/fonts/truetype/kochi/kochi-mincho.ttf",
@@ -119,13 +138,8 @@ bool SetupFontConfig() {
"/usr/share/fonts/truetype/ttf-indic-fonts-core/lohit_pa.ttf",
"/usr/share/fonts/truetype/ttf-punjabi-fonts/lohit_pa.ttf");
- base::FilePath ahem_font = base_path.Append("AHEM____.TTF");
- if (!FcConfigAppFontAddFile(
- font_config,
- reinterpret_cast<const FcChar8*>(ahem_font.value().c_str()))) {
- std::cerr << "Failed to load font " << ahem_font.value() << "\n";
+ if (!LoadFontResources(base_path, font_config))
return false;
- }
if (!FcConfigSetCurrent(font_config)) {
std::cerr << "Failed to set the default font configuration\n";
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698