Change clang_format.py to search for clang-format in buildtools

Change clang_format.py to search for clang-format in buildtools

BUG=none
R=brettw@chromium.org,nick@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280971

[ncarter (slow), 2014-06-25 18:02:04]

lgtm

[brettw, 2014-06-25 19:15:13]

lgtm

[jochen (gone - plz use gerrit), 2014-06-26 11:02:42]

I had to slightly change the logic in gclient_utils to fall back to the cwd +
'buildtools' if no .gclient file is found - most v8 developers use a full svn
checkout without .gclient

[ncarter (slow), 2014-06-26 18:03:00]

https://codereview.chromium.org/356733002/diff/20001/clang_format.py
File clang_format.py (right):

https://codereview.chromium.org/356733002/diff/20001/clang_format.py#newcode34
clang_format.py:34: 'clang-format' + gclient_utils.GetExeSuffix())
FWIW, the reason I'd gone with "clang_format" instead of "clang-format" is
because of the difficulty in importing a python module with hyphens in its path.
However, this was just defensive against a theoretical problem; we don't have
__init__.py's around anyhow.

[ncarter (slow), 2014-06-26 18:03:05]

lgtm

[ncarter (slow), 2014-06-26 18:03:06]

lgtm

[jochen (gone - plz use gerrit), 2014-06-26 19:24:17]

i'm still not quite happy with the logic, because it only works for a standalone
v8 checkout if you invoke clang-format from the root of the checkout.

I guess I'll try to come up with a better heuristic for v8

[jochen (gone - plz use gerrit), 2014-07-02 07:33:17]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:33:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jochen@chromium.org/356733002/40001

[commit-bot: I haz the power, 2014-07-02 07:35:32]

Change committed as 280971