Chromium Code Reviews| Index: net/ssl/channel_id_store.h |
| diff --git a/net/ssl/server_bound_cert_store.h b/net/ssl/channel_id_store.h |
| similarity index 79% |
| rename from net/ssl/server_bound_cert_store.h |
| rename to net/ssl/channel_id_store.h |
| index 0de0f3eebd86e2b7dd2b484ad1bdffb5082c3c48..3162aa685166c5f71307b78a756a67ccebb5a777 100644 |
| --- a/net/ssl/server_bound_cert_store.h |
| +++ b/net/ssl/channel_id_store.h |
| @@ -2,8 +2,8 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#ifndef NET_SSL_SERVER_BOUND_CERT_STORE_H_ |
| -#define NET_SSL_SERVER_BOUND_CERT_STORE_H_ |
| +#ifndef NET_SSL_CHANNEL_ID_STORE_H_ |
| +#define NET_SSL_CHANNEL_ID_STORE_H_ |
| #include <list> |
| #include <string> |
| @@ -20,22 +20,22 @@ namespace net { |
| // certificates are specified in |
| // http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-01.html. |
|
wtc
2014/07/01 19:50:54
Add a TODO comment to update this comment block.
Ryan Hamilton
2014/07/21 19:12:11
Done.
|
| -// Owned only by a single ServerBoundCertService object, which is responsible |
| +// Owned only by a single ChannelIDService object, which is responsible |
| // for deleting it. |
| -class NET_EXPORT ServerBoundCertStore |
| +class NET_EXPORT ChannelIDStore |
| : NON_EXPORTED_BASE(public base::NonThreadSafe) { |
| public: |
| - // The ServerBoundCert class contains a private key in addition to the server |
| + // The ChannelID class contains a private key in addition to the server |
| // cert. |
|
wtc
2014/07/01 19:50:54
server cert => cert
Ryan Hamilton
2014/07/21 19:12:11
Done.
|
| - class NET_EXPORT ServerBoundCert { |
| + class NET_EXPORT ChannelID { |
| public: |
| - ServerBoundCert(); |
| - ServerBoundCert(const std::string& server_identifier, |
| + ChannelID(); |
| + ChannelID(const std::string& server_identifier, |
| base::Time creation_time, |
| base::Time expiration_time, |
| const std::string& private_key, |
| const std::string& cert); |
|
wtc
2014/07/01 19:50:55
Fix the indentation of these parameters.
Ryan Hamilton
2014/07/21 19:12:11
Done.
|
| - ~ServerBoundCert(); |
| + ~ChannelID(); |
| // Server identifier. For domain bound certs, for instance "verisign.com". |
| const std::string& server_identifier() const { return server_identifier_; } |
| @@ -59,7 +59,7 @@ class NET_EXPORT ServerBoundCertStore |
| std::string cert_; |
| }; |
| - typedef std::list<ServerBoundCert> ServerBoundCertList; |
| + typedef std::list<ChannelID> ChannelIDList; |
| typedef base::Callback<void( |
| int, |
| @@ -67,17 +67,17 @@ class NET_EXPORT ServerBoundCertStore |
| base::Time, |
| const std::string&, |
| const std::string&)> GetCertCallback; |
| - typedef base::Callback<void(const ServerBoundCertList&)> GetCertListCallback; |
| + typedef base::Callback<void(const ChannelIDList&)> GetCertListCallback; |
| - virtual ~ServerBoundCertStore() {} |
| + virtual ~ChannelIDStore() {} |
| - // GetServerBoundCert may return the result synchronously through the |
| + // GetChannelID may return the result synchronously through the |
| // output parameters, in which case it will return either OK if a cert is |
| // found in the store, or ERR_FILE_NOT_FOUND if none is found. If the |
| - // result cannot be returned synchronously, GetServerBoundCert will |
| + // result cannot be returned synchronously, GetChannelID will |
| // return ERR_IO_PENDING and the callback will be called with the result |
| // asynchronously. |
| - virtual int GetServerBoundCert( |
| + virtual int GetChannelID( |
| const std::string& server_identifier, |
| base::Time* expiration_time, |
| std::string* private_key_result, |
| @@ -85,7 +85,7 @@ class NET_EXPORT ServerBoundCertStore |
| const GetCertCallback& callback) = 0; |
| // Adds a server bound cert and the corresponding private key to the store. |
| - virtual void SetServerBoundCert( |
| + virtual void SetChannelID( |
| const std::string& server_identifier, |
| base::Time creation_time, |
| base::Time expiration_time, |
| @@ -94,7 +94,7 @@ class NET_EXPORT ServerBoundCertStore |
| // Removes a server bound cert and the corresponding private key from the |
| // store. |
| - virtual void DeleteServerBoundCert( |
| + virtual void DeleteChannelID( |
| const std::string& server_identifier, |
| const base::Closure& completion_callback) = 0; |
| @@ -111,10 +111,10 @@ class NET_EXPORT ServerBoundCertStore |
| virtual void DeleteAll(const base::Closure& completion_callback) = 0; |
| // Returns all server bound certs and the corresponding private keys. |
| - virtual void GetAllServerBoundCerts(const GetCertListCallback& callback) = 0; |
| + virtual void GetAllChannelIDs(const GetCertListCallback& callback) = 0; |
| // Helper function that adds all certs from |list| into this instance. |
| - void InitializeFrom(const ServerBoundCertList& list); |
| + void InitializeFrom(const ChannelIDList& list); |
| // Returns the number of certs in the store. May return 0 if the backing |
| // store is not loaded yet. |
| @@ -128,4 +128,4 @@ class NET_EXPORT ServerBoundCertStore |
| } // namespace net |
| -#endif // NET_SSL_SERVER_BOUND_CERT_STORE_H_ |
| +#endif // NET_SSL_CHANNEL_ID_STORE_H_ |