Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7656)

Unified Diff: chrome/browser/chromeos/login/profile_auth_data.cc

Issue 356713005: Rename ServerBoundCert => ChannelID to reflect the current name (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/profile_auth_data.cc
diff --git a/chrome/browser/chromeos/login/profile_auth_data.cc b/chrome/browser/chromeos/login/profile_auth_data.cc
index 13be26ae39ee329209b621070369a85ac200c91b..7946fa066222bc2b6859bcc67c6760e9a1f014af 100644
--- a/chrome/browser/chromeos/login/profile_auth_data.cc
+++ b/chrome/browser/chromeos/login/profile_auth_data.cc
@@ -18,8 +18,8 @@
#include "net/http/http_auth_cache.h"
#include "net/http/http_network_session.h"
#include "net/http/http_transaction_factory.h"
-#include "net/ssl/server_bound_cert_service.h"
-#include "net/ssl/server_bound_cert_store.h"
+#include "net/ssl/channel_id_service.h"
+#include "net/ssl/channel_id_store.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
@@ -34,7 +34,7 @@ class ProfileAuthDataTransferer {
ProfileAuthDataTransferer(
content::BrowserContext* from_context,
content::BrowserContext* to_context,
- bool transfer_auth_cookies_and_server_bound_certs,
+ bool transfer_auth_cookies_and_channel_ids,
const base::Closure& completion_callback);
void BeginTransfer();
@@ -56,13 +56,13 @@ class ProfileAuthDataTransferer {
void OnCookiesToTransferRetrieved(const net::CookieList& cookies_to_transfer);
// Retrieve |from_context_|'s server bound certs. When the retrieval finishes,
wtc 2014/07/01 19:50:49 server bound certs => channel IDs Also fix lines
Ryan Hamilton 2014/07/21 19:12:05 Done.
- // OnServerBoundCertsToTransferRetrieved will be called with the result.
- void RetrieveServerBoundCertsToTransfer();
+ // OnChannelIDsToTransferRetrieved will be called with the result.
+ void RetrieveChannelIDsToTransfer();
// Callback that receives |from_context_|'s server bound certs. Calls
// MaybeTransferCookiesAndCerts() to try and perform the transfer.
- void OnServerBoundCertsToTransferRetrieved(
- const net::ServerBoundCertStore::ServerBoundCertList& certs_to_transfer);
+ void OnChannelIDsToTransferRetrieved(
+ const net::ChannelIDStore::ChannelIDList& certs_to_transfer);
wtc 2014/07/01 19:50:49 certs_to_transfer => channel_ids_to_transfer
Ryan Hamilton 2014/07/21 19:12:05 Done.
// If both auth cookies and server bound certs have been retrieved from
// |from_context| already, retrieve the contents of |to_context|'s cookie jar
@@ -80,28 +80,28 @@ class ProfileAuthDataTransferer {
scoped_refptr<net::URLRequestContextGetter> from_context_;
scoped_refptr<net::URLRequestContextGetter> to_context_;
- bool transfer_auth_cookies_and_server_bound_certs_;
+ bool transfer_auth_cookies_and_channel_ids_;
base::Closure completion_callback_;
net::CookieList cookies_to_transfer_;
- net::ServerBoundCertStore::ServerBoundCertList certs_to_transfer_;
+ net::ChannelIDStore::ChannelIDList certs_to_transfer_;
wtc 2014/07/01 19:50:49 certs_to_transfer_ => channel_ids_to_transfer_
Ryan Hamilton 2014/07/21 19:12:05 Done.
bool got_cookies_;
- bool got_server_bound_certs_;
+ bool got_channel_ids_;
};
ProfileAuthDataTransferer::ProfileAuthDataTransferer(
content::BrowserContext* from_context,
content::BrowserContext* to_context,
- bool transfer_auth_cookies_and_server_bound_certs,
+ bool transfer_auth_cookies_and_channel_ids,
const base::Closure& completion_callback)
: from_context_(from_context->GetRequestContext()),
to_context_(to_context->GetRequestContext()),
- transfer_auth_cookies_and_server_bound_certs_(
- transfer_auth_cookies_and_server_bound_certs),
+ transfer_auth_cookies_and_channel_ids_(
+ transfer_auth_cookies_and_channel_ids),
completion_callback_(completion_callback),
got_cookies_(false),
- got_server_bound_certs_(false) {
+ got_channel_ids_(false) {
}
void ProfileAuthDataTransferer::BeginTransfer() {
@@ -109,7 +109,7 @@ void ProfileAuthDataTransferer::BeginTransfer() {
// If we aren't transferring auth cookies or server bound certificates, post
// the completion callback immediately. Otherwise, it will be called when both
// auth cookies and server bound certificates have been transferred.
- if (!transfer_auth_cookies_and_server_bound_certs_) {
+ if (!transfer_auth_cookies_and_channel_ids_) {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, completion_callback_);
// Null the callback so that when Finish is called, the callback won't be
// called again.
@@ -124,9 +124,9 @@ void ProfileAuthDataTransferer::BeginTransfer() {
void ProfileAuthDataTransferer::BeginTransferOnIOThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
TransferProxyAuthCache();
- if (transfer_auth_cookies_and_server_bound_certs_) {
+ if (transfer_auth_cookies_and_channel_ids_) {
RetrieveCookiesToTransfer();
- RetrieveServerBoundCertsToTransfer();
+ RetrieveChannelIDsToTransfer();
} else {
Finish();
}
@@ -159,27 +159,27 @@ void ProfileAuthDataTransferer::OnCookiesToTransferRetrieved(
MaybeTransferCookiesAndCerts();
}
-void ProfileAuthDataTransferer::RetrieveServerBoundCertsToTransfer() {
+void ProfileAuthDataTransferer::RetrieveChannelIDsToTransfer() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- net::ServerBoundCertService* from_service =
- from_context_->GetURLRequestContext()->server_bound_cert_service();
- from_service->GetCertStore()->GetAllServerBoundCerts(
+ net::ChannelIDService* from_service =
+ from_context_->GetURLRequestContext()->channel_id_service();
+ from_service->GetCertStore()->GetAllChannelIDs(
base::Bind(
- &ProfileAuthDataTransferer::OnServerBoundCertsToTransferRetrieved,
+ &ProfileAuthDataTransferer::OnChannelIDsToTransferRetrieved,
base::Unretained(this)));
}
-void ProfileAuthDataTransferer::OnServerBoundCertsToTransferRetrieved(
- const net::ServerBoundCertStore::ServerBoundCertList& certs_to_transfer) {
+void ProfileAuthDataTransferer::OnChannelIDsToTransferRetrieved(
+ const net::ChannelIDStore::ChannelIDList& certs_to_transfer) {
wtc 2014/07/01 19:50:49 certs_to_transfer => channel_ids_to_transfer
Ryan Hamilton 2014/07/21 19:12:05 Done.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
certs_to_transfer_ = certs_to_transfer;
- got_server_bound_certs_ = true;
+ got_channel_ids_ = true;
MaybeTransferCookiesAndCerts();
}
void ProfileAuthDataTransferer::MaybeTransferCookiesAndCerts() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- if (!(got_cookies_ && got_server_bound_certs_))
+ if (!(got_cookies_ && got_channel_ids_))
return;
// Nothing to transfer over?
@@ -205,8 +205,8 @@ void ProfileAuthDataTransferer::OnTargetCookieJarContentsRetrieved(
to_context_->GetURLRequestContext()->cookie_store();
net::CookieMonster* to_monster = to_store->GetCookieMonster();
to_monster->InitializeFrom(cookies_to_transfer_);
- net::ServerBoundCertService* to_cert_service =
- to_context_->GetURLRequestContext()->server_bound_cert_service();
+ net::ChannelIDService* to_cert_service =
+ to_context_->GetURLRequestContext()->channel_id_service();
to_cert_service->GetCertStore()->InitializeFrom(certs_to_transfer_);
}
@@ -225,12 +225,12 @@ void ProfileAuthDataTransferer::Finish() {
void ProfileAuthData::Transfer(
content::BrowserContext* from_context,
content::BrowserContext* to_context,
- bool transfer_auth_cookies_and_server_bound_certs,
+ bool transfer_auth_cookies_and_channel_ids,
const base::Closure& completion_callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
(new ProfileAuthDataTransferer(from_context,
to_context,
- transfer_auth_cookies_and_server_bound_certs,
+ transfer_auth_cookies_and_channel_ids,
completion_callback))->BeginTransfer();
}

Powered by Google App Engine
This is Rietveld 408576698