Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7915)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 356713005: Rename ServerBoundCert => ChannelID to reflect the current name (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 8b066105e1be5a5f37985e252830e587c19774b9..c6ba9c5be9381b5ce9886ee45e0a28a0dfb2bcee 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -81,8 +81,8 @@
#include "net/disk_cache/disk_cache.h"
#include "net/http/http_cache.h"
#include "net/http/transport_security_state.h"
-#include "net/ssl/server_bound_cert_service.h"
-#include "net/ssl/server_bound_cert_store.h"
+#include "net/ssl/channel_id_service.h"
+#include "net/ssl/channel_id_store.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
#include "webkit/browser/quota/quota_manager.h"
@@ -203,7 +203,7 @@ BrowsingDataRemover::BrowsingDataRemover(Profile* profile,
waiting_for_clear_platform_keys_(false),
waiting_for_clear_plugin_data_(false),
waiting_for_clear_pnacl_cache_(false),
- waiting_for_clear_server_bound_certs_(false),
+ waiting_for_clear_channel_ids_(false),
waiting_for_clear_storage_partition_data_(false),
#if defined(ENABLE_WEBRTC)
waiting_for_clear_webrtc_logs_(false),
@@ -455,17 +455,17 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
// Server bound certs are not separated for protected and unprotected web
// origins. We check the origin_set_mask_ to prevent unintended deletion.
- if (remove_mask & REMOVE_SERVER_BOUND_CERTS &&
+ if (remove_mask & REMOVE_CHANNEL_IDS &&
origin_set_mask_ & BrowsingDataHelper::UNPROTECTED_WEB) {
content::RecordAction(
- UserMetricsAction("ClearBrowsingData_ServerBoundCerts"));
+ UserMetricsAction("ClearBrowsingData_ChannelIDs"));
// Since we are running on the UI thread don't call GetURLRequestContext().
net::URLRequestContextGetter* rq_context = profile_->GetRequestContext();
if (rq_context) {
- waiting_for_clear_server_bound_certs_ = true;
+ waiting_for_clear_channel_ids_ = true;
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- base::Bind(&BrowsingDataRemover::ClearServerBoundCertsOnIOThread,
+ base::Bind(&BrowsingDataRemover::ClearChannelIDsOnIOThread,
base::Unretained(this), base::Unretained(rq_context)));
}
}
@@ -751,7 +751,7 @@ bool BrowsingDataRemover::AllDone() {
!waiting_for_clear_domain_reliability_monitor_ &&
!waiting_for_clear_logged_in_predictor_ &&
!waiting_for_clear_networking_history_ &&
- !waiting_for_clear_server_bound_certs_ &&
+ !waiting_for_clear_channel_ids_ &&
wtc 2014/07/01 19:50:48 Nit: sort these, if you still have the patience.
Ryan Hamilton 2014/07/21 19:12:04 Done.
!waiting_for_clear_plugin_data_ &&
!waiting_for_clear_pnacl_cache_ &&
!waiting_for_clear_content_licenses_ && !waiting_for_clear_form_ &&
@@ -1108,18 +1108,18 @@ void BrowsingDataRemover::ClearCookiesOnIOThread(
base::Unretained(this)));
}
-void BrowsingDataRemover::ClearServerBoundCertsOnIOThread(
+void BrowsingDataRemover::ClearChannelIDsOnIOThread(
net::URLRequestContextGetter* rq_context) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- net::ServerBoundCertService* server_bound_cert_service =
- rq_context->GetURLRequestContext()->server_bound_cert_service();
- server_bound_cert_service->GetCertStore()->DeleteAllCreatedBetween(
+ net::ChannelIDService* channel_id_service =
+ rq_context->GetURLRequestContext()->channel_id_service();
+ channel_id_service->GetCertStore()->DeleteAllCreatedBetween(
delete_begin_, delete_end_,
- base::Bind(&BrowsingDataRemover::OnClearedServerBoundCertsOnIOThread,
+ base::Bind(&BrowsingDataRemover::OnClearedChannelIDsOnIOThread,
base::Unretained(this), base::Unretained(rq_context)));
}
-void BrowsingDataRemover::OnClearedServerBoundCertsOnIOThread(
+void BrowsingDataRemover::OnClearedChannelIDsOnIOThread(
net::URLRequestContextGetter* rq_context) {
// Need to close open SSL connections which may be using the channel ids we
// are deleting.
@@ -1129,13 +1129,13 @@ void BrowsingDataRemover::OnClearedServerBoundCertsOnIOThread(
NotifySSLConfigChange();
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
- base::Bind(&BrowsingDataRemover::OnClearedServerBoundCerts,
+ base::Bind(&BrowsingDataRemover::OnClearedChannelIDs,
base::Unretained(this)));
}
-void BrowsingDataRemover::OnClearedServerBoundCerts() {
+void BrowsingDataRemover::OnClearedChannelIDs() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- waiting_for_clear_server_bound_certs_ = false;
+ waiting_for_clear_channel_ids_ = false;
NotifyAndDeleteIfDone();
}

Powered by Google App Engine
This is Rietveld 408576698