src/compiler.cc - Issue 356713004: Compile optimized code with active debugger but no break points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 356713004: Compile optimized code with active debugger but no break points. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index f471224b42c5430f7f2c551efe569f0e10609990..7b4afe375f9e5346ddf8da8ea38423b46ded7344 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -307,7 +307,9 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {

if (FLAG_always_full_compiler) return AbortOptimization();

// Do not use crankshaft if compiling for debugging.

- if (info()->is_debug()) return AbortOptimization(kDebuggerIsActive);

+ if (isolate()->DebuggerHasBreakPoints()) {

+ return AbortOptimization(kDebuggerIsActive);

+ }

// Limit the number of times we re-compile a functions with

// the optimizing compiler.

« no previous file with comments | « src/codegen.cc ('k') | test/mjsunit/debug-compile-optimized.js » ('j') | no next file with comments »