Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 356703002: Use IDL argument default values in modules/encoding/ (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use IDL argument default values in modules/encoding/ Replace bogus 'null' default values for DOMString/ScalarValueString arguments with the actual default values from the spec, and remove the handling of null strings in the C++ implementation. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M Source/modules/encoding/TextDecoder.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 2 chunks +7 lines, -11 lines 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jens Widell
PTAL
6 years, 6 months ago (2014-06-25 06:32:37 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-25 14:11:06 UTC) #2
Jens Widell
On 2014/06/25 14:11:06, jsbell (on vacation) wrote: > lgtm Thanks! Don't forget to be on ...
6 years, 6 months ago (2014-06-25 14:12:51 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-25 14:24:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/356703002/1
6 years, 6 months ago (2014-06-25 14:25:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-25 15:47:33 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 16:52:09 UTC) #7
Message was sent while issue was closed.
Change committed as 176934

Powered by Google App Engine
This is Rietveld 408576698