Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 356573003: NaCl documentation: improve building documentation (Closed)

Created:
6 years, 6 months ago by JF
Modified:
6 years, 6 months ago
Reviewers:
Derek Schuff, binji
CC:
binji+watch_chromium.org, chromium-reviews, native-client-reviews_googlegroups.com, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

NaCl documentation: improve building documentation R= dschuff@chromium.org TEST=none BUG=none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279757

Patch Set 1 #

Total comments: 21

Patch Set 2 : Address dschuff and binji comments. #

Patch Set 3 : Address dschuff's comments. #

Patch Set 4 : s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -135 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 3 15 chunks +92 lines, -67 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 2 3 16 chunks +93 lines, -67 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
JF
6 years, 6 months ago (2014-06-24 18:05:01 UTC) #1
Derek Schuff
https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, Linux, and ...
6 years, 6 months ago (2014-06-24 18:33:42 UTC) #2
binji
https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode267 native_client_sdk/src/doc/devguide/devcycle/building.rst:267: size and on-device translation speed. On 2014/06/24 18:33:42, Derek ...
6 years, 6 months ago (2014-06-24 20:51:48 UTC) #3
JF
Updated, PTAL. https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, ...
6 years, 6 months ago (2014-06-25 01:27:47 UTC) #4
Derek Schuff
otherwise LGTM https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, ...
6 years, 6 months ago (2014-06-25 17:27:02 UTC) #5
JF
https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, Linux, and ...
6 years, 6 months ago (2014-06-25 17:44:01 UTC) #6
binji
lgtm https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, Linux, ...
6 years, 6 months ago (2014-06-25 17:58:15 UTC) #7
JF
https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/356573003/diff/1/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode33 native_client_sdk/src/doc/devguide/devcycle/building.rst:33: will run on Windows, Mac OS X, Linux, and ...
6 years, 6 months ago (2014-06-25 18:03:04 UTC) #8
JF
The CQ bit was checked by jfb@chromium.org
6 years, 6 months ago (2014-06-25 18:08:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/356573003/60001
6 years, 6 months ago (2014-06-25 18:10:15 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 18:15:11 UTC) #11
Message was sent while issue was closed.
Change committed as 279757

Powered by Google App Engine
This is Rietveld 408576698