content/browser/geolocation/geolocation_dispatcher_host.cc - Issue 356543003: Audit the last usage of Geolocation and Notification permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/geolocation_dispatcher_host.cc

Issue 356543003: Audit the last usage of Geolocation and Notification permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_browsertest.cc ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/geolocation_dispatcher_host.cc

diff --git a/content/browser/geolocation/geolocation_dispatcher_host.cc b/content/browser/geolocation/geolocation_dispatcher_host.cc

index ad1f2fcc4441f138726f67d6f0e8e049302e5962..e6a560b30011060f309b9584e2104a5286b8568e 100644

--- a/content/browser/geolocation/geolocation_dispatcher_host.cc

+++ b/content/browser/geolocation/geolocation_dispatcher_host.cc

@@ -130,6 +130,15 @@ void GeolocationDispatcherHost::OnLocationUpdate(

for (std::map<RenderFrameHost*, bool>::iterator i = updating_frames_.begin();

i != updating_frames_.end(); ++i) {

+ RenderFrameHost* topFrame = i->first;

jam 2014/07/14 18:20:53 nit: top_frame per style guide

Daniel Nishi 2014/07/14 22:25:05 Done.

+ while (topFrame->GetParent()) {

+ topFrame = topFrame->GetParent();

+ }

+ GetContentClient()->browser()->DidUseGeolocationPermission(

+ web_contents(),

+ i->first->GetLastCommittedURL().GetOrigin(),

+ topFrame->GetLastCommittedURL().GetOrigin());

i->first->Send(new GeolocationMsg_PositionUpdated(

i->first->GetRoutingID(), geoposition));

}