Audit the last usage of Geolocation and Notification permissions.

chrome/browser/notifications/desktop_notification_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/desktop_notification_service.h"
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 415 matching lines @@
                  chrome::NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED,
                  content::Source<Profile>(profile_));
 }
 
 DesktopNotificationService::~DesktopNotificationService() {
 }
 
 void DesktopNotificationService::GrantPermission(const GURL& origin) {
   ContentSettingsPattern primary_pattern =
       ContentSettingsPattern::FromURLNoWildcard(origin);
+  profile_->GetHostContentSettingsMap()->UpdateLastUsage(

[dewittj, 2014/06/26 15:56:51]

Why isn't this just done inside SetContentSetting?

[Daniel Nishi, 2014/06/26 20:31:25]

Good point. I've moved this part into SetContentSetting.

+      origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   profile_->GetHostContentSettingsMap()->SetContentSetting(
       primary_pattern,
       ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
       NO_RESOURCE_IDENTIFIER,
       CONTENT_SETTING_ALLOW);
 }
 
 void DesktopNotificationService::DenyPermission(const GURL& origin) {
   ContentSettingsPattern primary_pattern =
@@ skipping 59 matching lines @@
     const GURL& origin,
     content::RenderFrameHost* render_frame_host,
     const base::Closure& callback) {
   // If |origin| hasn't been seen before and the default content setting for
   // notifications is "ask", show an infobar.
   // The cache can only answer queries on the IO thread once it's initialized,
   // so don't ask the cache.
   WebContents* web_contents = WebContents::FromRenderFrameHost(
       render_frame_host);
   ContentSetting setting = GetContentSetting(origin);
+
+  if (setting == CONTENT_SETTING_ALLOW) {

[dewittj, 2014/06/26 15:56:51]

why only content setting allow?  This is probably better added to
GetContentSetting or down farther in the host content settings map.

[Daniel Nishi, 2014/06/26 20:31:25]

It's on allow because we're trying to track when the permission is actually
given, rather than just when it is requested. Checking it here handles the
non-interactive case.

GetContentSetting makes |this| const, so I didn't want to modify anything in
that call.

Would adding a non-const secondary getter that also logged the last usage be
preferable?

+    profile_->GetHostContentSettingsMap()->UpdateLastUsage(
+        origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
+  }
+
   if (setting == CONTENT_SETTING_ASK) {
     if (PermissionBubbleManager::Enabled()) {
       PermissionBubbleManager* bubble_manager =
           PermissionBubbleManager::FromWebContents(web_contents);
       if (bubble_manager) {
         bubble_manager->AddRequest(new NotificationPermissionRequest(
             this,
             origin,
             DisplayNameForOriginInProcessId(
                 origin, render_frame_host->GetProcess()->GetID()),
@@ skipping 227 matching lines @@
   // Tell the IO thread that this extension's permission for notifications
   // has changed.
   extensions::InfoMap* extension_info_map =
       extensions::ExtensionSystem::Get(profile_)->info_map();
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&extensions::InfoMap::SetNotificationsDisabled,
                  extension_info_map, notifier_id.id, !enabled));
 #endif
 }