Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 356543003: Audit the last usage of Geolocation and Notification permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 467
468 // Request permission to access protected media identifier. |result_callback 468 // Request permission to access protected media identifier. |result_callback
469 // will tell whether it's permitted. If |cancel_callback| is non-null, it's 469 // will tell whether it's permitted. If |cancel_callback| is non-null, it's
470 // set to a callback which can be used to cancel the permission request. 470 // set to a callback which can be used to cancel the permission request.
471 virtual void RequestProtectedMediaIdentifierPermission( 471 virtual void RequestProtectedMediaIdentifierPermission(
472 WebContents* web_contents, 472 WebContents* web_contents,
473 const GURL& origin, 473 const GURL& origin,
474 base::Callback<void(bool)> result_callback, 474 base::Callback<void(bool)> result_callback,
475 base::Closure* cancel_callback); 475 base::Closure* cancel_callback);
476 476
477 // Invoked when the Geolocation API uses its permission.
478 virtual void DidUseGeolocationPermission(WebContents* web_contents,
jam 2014/07/14 18:20:53 nit: put this at line 456 so it's right after the
Daniel Nishi 2014/07/14 22:25:05 Done.
479 const GURL& primary_url,
jam 2014/07/14 18:20:53 nit: primary and secondary urls is ambiguous. use
Daniel Nishi 2014/07/14 22:25:05 Done.
480 const GURL& secondary_url);
481
477 // Returns true if the given page is allowed to open a window of the given 482 // Returns true if the given page is allowed to open a window of the given
478 // type. If true is returned, |no_javascript_access| will indicate whether 483 // type. If true is returned, |no_javascript_access| will indicate whether
479 // the window that is created should be scriptable/in the same process. 484 // the window that is created should be scriptable/in the same process.
480 // This is called on the IO thread. 485 // This is called on the IO thread.
481 virtual bool CanCreateWindow(const GURL& opener_url, 486 virtual bool CanCreateWindow(const GURL& opener_url,
482 const GURL& opener_top_level_frame_url, 487 const GURL& opener_top_level_frame_url,
483 const GURL& source_origin, 488 const GURL& source_origin,
484 WindowContainerType container_type, 489 WindowContainerType container_type,
485 const GURL& target_url, 490 const GURL& target_url,
486 const Referrer& referrer, 491 const Referrer& referrer,
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 // Allows an embedder to provide its own ExternalVideoSurfaceContainer 653 // Allows an embedder to provide its own ExternalVideoSurfaceContainer
649 // implementation. Return NULL to disable external surface video. 654 // implementation. Return NULL to disable external surface video.
650 virtual ExternalVideoSurfaceContainer* 655 virtual ExternalVideoSurfaceContainer*
651 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents); 656 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
652 #endif 657 #endif
653 }; 658 };
654 659
655 } // namespace content 660 } // namespace content
656 661
657 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 662 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698