Audit the last usage of Geolocation and Notification permissions.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 456 matching lines @@
 
   // Request permission to access protected media identifier. |result_callback
   // will tell whether it's permitted. If |cancel_callback| is non-null, it's
   // set to a callback which can be used to cancel the permission request.
   virtual void RequestProtectedMediaIdentifierPermission(
       WebContents* web_contents,
       const GURL& origin,
       base::Callback<void(bool)> result_callback,
       base::Closure* cancel_callback);
 
+  // Informs the content settings host map that a permission has been used.

[Bernhard Bauer, 2014/07/14 10:50:33]

Informs whom? Content settings host map (actually host content settings map) is
not a thing that content/ knows about.

[Daniel Nishi, 2014/07/14 17:12:54]

Removed reference to chrome concept.

+  virtual void UseContentSettingPermission(WebContents* web_contents,

[Bernhard Bauer, 2014/07/14 10:50:33]

I would probably call this "DidUse..." or something. Right now it reads like an
imperative.

[Daniel Nishi, 2014/07/14 17:12:54]

Done.

+                                           const GURL& primary_url,
+                                           const GURL& secondary_url,
+                                           const std::string& setting_type);

[Bernhard Bauer, 2014/07/14 10:50:33]

This is somewhat weird as a content embedder interface. What is the setting
passed here? (Looking at the whole picture, I know that it will be the string
"geolocation", but that's a content setting type name defined in chrome/. The
fact that you need to repeat the constant inside of GeolocationDispatcherHost
should be a bit of a red flag).

We also don't actually use this for arbitrary content setting types. TBH, I
would just make this a specific method for geolocation.

You could also move this to WebContentsObserver. The only reason why other
methods around here that take a WebContents are not on WebContentsObserver is
because there is one particular object that needs to handle them (to decide
about a permission), whereas this is just notifying whoever is interested.

[Daniel Nishi, 2014/07/14 17:12:54]

I'm not sure if WebContentsObserver is the right landing place since the header
implies it is for classes interested in page load events, which a permission use
doesn't seem to be.

It is a good point that it is only used for geolocation. I've changed the method
to be specific.

+
   // Returns true if the given page is allowed to open a window of the given
   // type. If true is returned, |no_javascript_access| will indicate whether
   // the window that is created should be scriptable/in the same process.
   // This is called on the IO thread.
   virtual bool CanCreateWindow(const GURL& opener_url,
                                const GURL& opener_top_level_frame_url,
                                const GURL& source_origin,
                                WindowContainerType container_type,
                                const GURL& target_url,
                                const Referrer& referrer,
@@ skipping 161 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return NULL to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_