Audit the last usage of Geolocation and Notification permissions.

chrome/browser/chrome_content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "chrome/common/chrome_version_info.h"
 #include "content/public/browser/content_browser_client.h"
 
 #if defined(OS_ANDROID)

[Bernhard Bauer, 2014/07/14 10:50:32]

While you're here, this file could use some love...

(yay yak-shaving!)

This #ifdef seems strange and wrong. There's a scoped_ptr used below
unconditionally.

[Daniel Nishi, 2014/07/14 17:12:53]

Done.

 #include "base/memory/scoped_ptr.h"
 #endif
 
+class Profile;

[Bernhard Bauer, 2014/07/14 10:50:32]

This is unnecessary.

[Daniel Nishi, 2014/07/14 17:12:54]

Removed.

+
 namespace base {
 class CommandLine;
 }
 
 namespace content {
 class QuotaPermissionContext;
 }
 
 namespace extensions {
 class BrowserPermissionsPolicyDelegate;
@@ skipping 174 matching lines @@
       bool user_gesture,
       base::Callback<void(bool)> result_callback,
       base::Closure* cancel_callback) OVERRIDE;
   virtual void RequestMidiSysExPermission(
       content::WebContents* web_contents,
       int bridge_id,
       const GURL& requesting_frame,
       bool user_gesture,
       base::Callback<void(bool)> result_callback,
       base::Closure* cancel_callback) OVERRIDE;
+  virtual void UseContentSettingPermission(
+      content::WebContents* web_contents,
+      const GURL& primary_url,
+      const GURL& secondary_url,
+      const std::string& setting_type) OVERRIDE;
   virtual void RequestProtectedMediaIdentifierPermission(
       content::WebContents* web_contents,
       const GURL& origin,
       base::Callback<void(bool)> result_callback,
       base::Closure* cancel_callback) OVERRIDE;
   virtual bool CanCreateWindow(const GURL& opener_url,
                                const GURL& opener_top_level_frame_url,
                                const GURL& source_origin,
                                WindowContainerType container_type,
                                const GURL& target_url,
@@ skipping 71 matching lines @@
  private:
 #if defined(ENABLE_WEBRTC)
   // Copies disable WebRTC encryption switch depending on the channel.
   static void MaybeCopyDisableWebRtcEncryptionSwitch(
       base::CommandLine* to_command_line,
       const base::CommandLine& from_command_line,
       VersionInfo::Channel channel);
 #endif
 
   void FileSystemAccessed(
     const GURL& url,

[Bernhard Bauer, 2014/07/14 10:50:32]

Needs to be indented two more spaces.

[Daniel Nishi, 2014/07/14 17:12:54]

Done.

     const std::vector<std::pair<int, int> >& render_frames,
     base::Callback<void(bool)> callback,
     bool allow);
 
 #if defined(ENABLE_EXTENSIONS)
 void GuestPermissionRequestHelper(

[Bernhard Bauer, 2014/07/14 10:50:32]

Two more spaces (also below)

[Daniel Nishi, 2014/07/14 17:12:54]

Done.

     const GURL& url,
     const std::vector<std::pair<int, int> >& render_frames,
     base::Callback<void(bool)> callback,
     bool allow);
 
 static void RequestFileSystemPermissionOnUIThread(
     int render_process_id,
     int render_frame_id,
     const GURL& url,
     bool allowed_by_default,
@@ skipping 13 matching lines @@
       permissions_policy_delegate_;
 
   // The prerender tracker used to determine whether a render process is used
   // for prerendering and an override cookie store must be provided.
   // This needs to be kept as a member rather than just looked up from
   // the profile due to initialization ordering, as well as due to threading.
   // It is initialized on the UI thread when the ResoureDispatcherHost is
   // created. It is used only the IO thread.
   prerender::PrerenderTracker* prerender_tracker_;
 
    base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;

[Bernhard Bauer, 2014/07/14 10:50:32]

One less space.

[Daniel Nishi, 2014/07/14 17:12:54]

Done.

 
   friend class DisableWebRtcEncryptionFlagTest;

[Bernhard Bauer, 2014/07/14 10:50:32]

friend declarations go right after private:

[Daniel Nishi, 2014/07/14 17:12:54]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_