Audit the last usage of Geolocation and Notification permissions.

content/browser/geolocation/geolocation_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/geolocation_dispatcher_host.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/renderer_host/render_message_filter.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/geoposition.h"
 #include "content/common/geolocation_messages.h"
 
 namespace content {
 namespace {
 
+const char kGeolocationPermission[] = "geolocation";
+
 // Geoposition error codes for reporting in UMA.
 enum GeopositionErrorCode {
   // NOTE: Do not renumber these as that would confuse interpretation of
   // previously logged data. When making changes, also update the enum list
   // in tools/metrics/histograms/histograms.xml to keep it in sync.
 
   // There was no error.
   GEOPOSITION_ERROR_CODE_NONE = 0,
 
   // User denied use of geolocation.
@@ skipping 89 matching lines @@
 void GeolocationDispatcherHost::OnLocationUpdate(
     const Geoposition& geoposition) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   RecordGeopositionErrorCode(geoposition.error_code);
   if (paused_)
     return;
 
   for (std::map<RenderFrameHost*, bool>::iterator i = updating_frames_.begin();
        i != updating_frames_.end(); ++i) {
+    RenderFrameHost* topFrame = i->first;
+    while (topFrame->GetParent()) {
+      topFrame = topFrame->GetParent();
+    }
+    GetContentClient()->browser()->UseContentSettingPermission(
+        web_contents(),
+        topFrame->GetLastCommittedURL().GetOrigin(),

[Michael van Ouwerkerk, 2014/07/08 17:02:18]

Sorry to keep going on about this, but from what I understand we try to
distinguish the requesting frame from the top level frame. So this line should
be the requesting frame, the next line should be the top level frame.

[Daniel Nishi, 2014/07/08 18:14:35]

I think I understand now. So this change here should be appropriate?

+        topFrame->GetLastCommittedURL().GetOrigin(),
+        kGeolocationPermission);
+
     i->first->Send(new GeolocationMsg_PositionUpdated(
         i->first->GetRoutingID(), geoposition));
   }
 }
 
 void GeolocationDispatcherHost::OnRequestPermission(
     RenderFrameHost* render_frame_host,
     int bridge_id,
     const GURL& requesting_frame,
     bool user_gesture) {
@@ skipping 105 matching lines @@
 
       pending_permissions_.erase(pending_permissions_.begin() + i);
       return;
     }
   }
 
   NOTREACHED();
 }
 
 }  // namespace content