Audit the last usage of Geolocation and Notification permissions.

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include <functional>
 #include <string>
 #include <vector>
 
@@ skipping 183 matching lines @@
     content::WebContents* web_contents,
     const PermissionRequestID& id,
     const GURL& requesting_frame,
     bool user_gesture,
     const GURL& embedder,
     const std::string& accept_button_label,
     base::Callback<void(bool)> callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   ContentSetting content_setting =
-     profile_->GetHostContentSettingsMap()->GetContentSetting(
-          requesting_frame, embedder, CONTENT_SETTINGS_TYPE_GEOLOCATION,
-          std::string());
+      profile_->GetHostContentSettingsMap()
+          ->GetContentSettingAndMaybeUpdateLastUsage(

[Michael van Ouwerkerk, 2014/07/01 11:02:23]

This doesn't make sense to me. If permission has already been granted by the
user (CONTENT_SETTING_ALLOW) then this will update the timestamp for Geolocation
usage to now. This does not, however, capture the case in the default block
below. And it does not capture actual usage of the API, though one may expect it
to be used if permission is being requested. Still it is better to actually
track usage in a place where geolocation data is sent to the renderer.

[Daniel Nishi, 2014/07/01 18:37:48]

This location only tracks if permission is asked for and granted (because it was
set in the past). I was thinking that the user could be interested in who was
asking for permission, even if they haven't used it yet.

This isn't the one trying to track the usage, the |OnStartUpdating| part was
supposed to do that, but I'm moving it to OnLocationUpdate by your suggestion.

As for the default block, that gets captured if they choose Allow on the request
when setting the permission in HostContentSettingsMap.

[Michael van Ouwerkerk, 2014/07/02 18:51:15]

Cool, thanks.

+              requesting_frame,
+              embedder,
+              CONTENT_SETTINGS_TYPE_GEOLOCATION,
+              std::string());
   switch (content_setting) {
     case CONTENT_SETTING_BLOCK:
       PermissionDecided(id, requesting_frame, embedder, callback, false);
       break;
     case CONTENT_SETTING_ALLOW:
       PermissionDecided(id, requesting_frame, embedder, callback, true);
       break;
     default:
       if (PermissionBubbleManager::Enabled()) {
         PermissionBubbleManager* mgr =
@@ skipping 107 matching lines @@
     if (cancelling != NULL && web_contents != NULL &&
         PermissionBubbleManager::FromWebContents(web_contents) != NULL) {
       PermissionBubbleManager::FromWebContents(web_contents)->
           CancelRequest(cancelling);
     }
     return;
   }
 
   QueueController()->CancelInfoBarRequest(id);
 }