Audit the last usage of Geolocation and Notification permissions.

chrome/browser/content_settings/host_content_settings_map.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Maps hostnames to custom content settings.  Written on the UI thread and read
 // on any thread.  One instance per profile.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/threading/platform_thread.h"
 #include "base/tuple.h"
 #include "chrome/browser/content_settings/content_settings_observer.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_pattern.h"
 #include "chrome/common/content_settings_types.h"
 
 class ExtensionService;
 class GURL;
 class PrefService;
 
 namespace base {
+class Clock;
 class Value;
 }
 
 namespace content_settings {
 class ProviderInterface;
 }
 
 namespace user_prefs {
 class PrefRegistrySyncable;
 }
@@ skipping 152 matching lines @@
   // Returns the ProviderType associated with the given source string.
   // TODO(estade): I regret adding this. At the moment there are no legitimate
   // uses. We should stick to ProviderType rather than string so we don't have
   // to convert backwards.
   static ProviderType GetProviderTypeFromSource(const std::string& source);
 
   bool is_off_the_record() const {
     return is_off_the_record_;
   }
 
+  // Returns a single |ContentSetting| which applies to the given URLs, just as
+  // |GetContentSetting| does. If the setting is allowed, it also records the
+  // last usage to preferences.
+  //
+  // This should only be called on the UI thread, unlike |GetContentSetting|.
+  ContentSetting GetContentSettingAndMaybeUpdateLastUsage(
+      const GURL& primary_url,

[Michael van Ouwerkerk, 2014/07/01 12:53:36]

Do primary_url and secondary_url correspond to requesting_frame and embedder?

[Daniel Nishi, 2014/07/01 18:37:48]

That's how it seems to work from Geolocations permissions context. There's a bit
of a discrepancy in how Geolocation & Midi do this and how Notifications does
this.

Notifications seems to throw the SecurityOrigin in a GURL and say it's both,
whereas Geolocation and Midi make a distinction between requesting_frame and
embedder.

[Michael van Ouwerkerk, 2014/07/02 18:51:15]

Right. It's for distinguishing between iframes and top level frames. We'll need
to sort out the terminology for this across chrome, but that's for a later cl,
probably for someone else.

+      const GURL& secondary_url,
+      ContentSettingsType content_type,
+      const std::string& resource_identifier);
+
+  void UpdateLastUsage(const GURL& primary_url,

[Michael van Ouwerkerk, 2014/07/01 11:02:23]

Please document this public method.

[Daniel Nishi, 2014/07/01 18:37:48]

Done.

+                       const GURL& secondary_url,
+                       ContentSettingsType content_type);
+
+  // Returns the last time the pattern that matches the URL has requested
+  // permission for the |content_type| setting.
+  base::Time GetLastUsage(const GURL& primary_url,
+                          const GURL& secondary_url,
+                          ContentSettingsType content_type);
+
+  // Returns the last time the pattern has requested permission for the
+  // |content_type| setting.
+  base::Time GetLastUsageByPattern(
+      const ContentSettingsPattern& primary_pattern,
+      const ContentSettingsPattern& secondary_pattern,
+      ContentSettingsType content_type);
+
+  // Passes ownership of |clock|.
+  void SetPrefClockForTesting(base::Clock* clock);
+
  private:
   friend class base::RefCountedThreadSafe<HostContentSettingsMap>;
   friend class HostContentSettingsMapTest_NonDefaultSettings_Test;
 
   typedef std::map<ProviderType, content_settings::ProviderInterface*>
       ProviderMap;
   typedef ProviderMap::iterator ProviderIterator;
   typedef ProviderMap::const_iterator ConstProviderIterator;
 
   virtual ~HostContentSettingsMap();
@@ skipping 17 matching lines @@
       const std::string& resource_identifier,
       ContentSettingsForOneType* settings,
       bool incognito) const;
 
   // Call UsedContentSettingsProviders() whenever you access
   // content_settings_providers_ (apart from initialization and
   // teardown), so that we can DCHECK in RegisterExtensionService that
   // it is not being called too late.
   void UsedContentSettingsProviders() const;
 
+  // Convenience method for updating the last usage of a content type for a
+  // pattern.
+  void UpdateLastUsageByPattern(const ContentSettingsPattern& primary_pattern,
+                                const ContentSettingsPattern& secondary_pattern,
+                                ContentSettingsType content_type);
+
 #ifndef NDEBUG
   // This starts as the thread ID of the thread that constructs this
   // object, and remains until used by a different thread, at which
   // point it is set to base::kInvalidThreadId. This allows us to
   // DCHECK on unsafe usage of content_settings_providers_ (they
   // should be set up on a single thread, after which they are
   // immutable).
   mutable base::PlatformThreadId used_from_thread_id_;
 #endif
 
   // Weak; owned by the Profile.
   PrefService* prefs_;
 
   // Whether this settings map is for an OTR session.
   bool is_off_the_record_;
 
   // Content setting providers. This is only modified at construction
   // time and by RegisterExtensionService, both of which should happen
   // before any other uses of it.
   ProviderMap content_settings_providers_;
 
   DISALLOW_COPY_AND_ASSIGN(HostContentSettingsMap);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_