Add implicit constraints from pub onto stack_trace and source_maps.

sdk/lib/_internal/pub/test/implicit_dependency_test.dart

Index: sdk/lib/_internal/pub/test/implicit_dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/implicit_dependency_test.dart b/sdk/lib/_internal/pub/test/implicit_dependency_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..288c7579623e7dbac098c226e6997d41780f1c50
--- /dev/null
+++ b/sdk/lib/_internal/pub/test/implicit_dependency_test.dart
@@ -0,0 +1,124 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:scheduled_test/scheduled_test.dart';
+
+import 'descriptor.dart' as d;
+import 'test_pub.dart';
+import '../lib/src/barback.dart' as barback;
+import '../lib/src/version.dart';
+
+main() {
+  initConfig();
+
+  forBothPubGetAndUpgrade((command) {
+    integration("implicitly constrains it to versions pub supports", () {
+      servePackages([
+        packageMap("barback", current("barback")),
+        packageMap("stack_trace", previous("stack_trace")),
+        packageMap("stack_trace", current("stack_trace")),
+        packageMap("stack_trace", nextPatch("stack_trace")),
+        packageMap("stack_trace", max("stack_trace")),
+        packageMap("source_maps", current("source_maps"))
+      ]);
+
+      d.appDir({
+        "barback": "any"
+      }).create();
+
+      pubCommand(command);
+
+      d.packagesDir({"stack_trace": nextPatch("stack_trace")}).validate();
+    });
+
+    integration("pub's implicit constraint uses the same source and "
+        "description as a dependency oerride", () {

[Bob Nystrom, 2014/06/26 16:37:34]

"oerride" -> "override". or maybe "o'erride" if you're feeling poetic.

[nweiz, 2014/06/26 20:03:48]

Done.

+      servePackages([
+        packageMap("barback", current("barback")),
+        packageMap("stack_trace", nextPatch("stack_trace")),
+        packageMap("source_maps", current("source_maps"))
+      ]);
+
+      d.dir("stack_trace", [
+        d.libDir("stack_trace", 'stack_trace ${current("stack_trace")}'),
+        d.libPubspec("stack_trace", current("stack_trace"))
+      ]).create();
+
+      d.dir(appPath, [
+        d.pubspec({
+          "name": "myapp",
+          "dependencies": {"barback": "any"},
+          "dependency_overrides": {
+            "stack_trace": {"path": "../stack_trace"},
+          }
+        })
+      ]).create();
+
+      pubCommand(command);
+
+      d.packagesDir({

[Bob Nystrom, 2014/06/26 16:37:34]

Comment that this validates that stack_trace's version is the path one, which
differs from the hosted version.

[nweiz, 2014/06/26 20:03:48]

Done.

+        "stack_trace": current("stack_trace")
+      }).validate();
+    });
+
+    integration("doesn't add a constraint if barback isn't in the package "
+        "graph", () {
+      servePackages([
+        packageMap("stack_trace", previous("stack_trace")),
+        packageMap("stack_trace", current("stack_trace")),
+        packageMap("stack_trace", nextPatch("stack_trace")),
+        packageMap("stack_trace", max("stack_trace")),
+        packageMap("source_maps", current("source_maps"))
+      ]);
+
+      d.appDir({
+        "stack_trace": "any"
+      }).create();
+
+      pubCommand(command);
+
+      d.packagesDir({"stack_trace": max("stack_trace")}).validate();
+    });
+  });
+
+  integration("unlocks if the locked version doesn't meet pub's "
+      "constraint", () {
+    servePackages([
+      packageMap("barback", current("barback")),
+      packageMap("stack_trace", previous("stack_trace")),
+      packageMap("stack_trace", current("stack_trace")),
+      packageMap("source_maps", current("source_maps"))
+    ]);
+
+    d.appDir({"barback": "any"}).create();
+
+    // Hand-create a lockfile to pin the package to an older version.
+    createLockFile("myapp", hosted: {
+      "barback": current("barback"),
+      "stack_trace": previous("stack_trace")
+    });
+
+    pubGet();
+
+    // It should be upgraded.
+    d.packagesDir({
+      "stack_trace": current("stack_trace")
+    }).validate();
+  });
+}
+
+String current(String packageName) =>
+    barback.pubConstraints[packageName].min.toString();
+
+String previous(String packageName) {
+  var constraint = barback.pubConstraints[packageName];
+  return new Version(constraint.min.major, constraint.min.minor - 1, 0)
+      .toString();
+}
+
+String nextPatch(String packageName) =>
+    barback.pubConstraints[packageName].min.nextPatch.toString();
+
+String max(String packageName) =>
+    barback.pubConstraints[packageName].max.toString();