Cleanup IndexedDBIO unit tests using GoogleMock.

Cleanup IndexedDBIO unit tests using GoogleMock.

Previous tests had the following limitations:

1. Not all ASSERT/EXPECT's were within the test functions.
2. Not verifying that OpenLevelDB was ever called.
3. Unused MockErrorLevelDBFactory::expect_destroy.
4. Explicitly doing things (like functionXXX called) which we get for
   free by using GoogleMock.

BUG=388012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283995

[cmumford, 2014-06-24 21:35:06]

Note: the tests *did* work before. This is just some refactoring to clean up the
tests and enhance them slightly.

[ericu, 2014-06-24 23:57:47]

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
File content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
(right):

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:82:
leveldb::Status open_error_;
Initialize open_error_.

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:101:
EXPECT_CALL(mock_leveldb_factory, DestroyLevelDB(_)).Times(Exactly(1));
What causes these expectations to be verified?  I don't see a destructor that
would do it...is there some magic, or are we missing a derivation that leads
back to FunctionMockerBase somehow?

[cmumford, 2014-06-25 00:05:28]

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
File content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
(right):

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:82:
leveldb::Status open_error_;
On 2014/06/24 23:57:47, ericu wrote:
> Initialize open_error_.

The default constructor for leveldb::Status constructs an OK() object. Do you
still want to be explicit about this?

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:101:
EXPECT_CALL(mock_leveldb_factory, DestroyLevelDB(_)).Times(Exactly(1));
On 2014/06/24 23:57:47, ericu wrote:
> What causes these expectations to be verified?  I don't see a destructor that
> would do it...is there some magic, or are we missing a derivation that leads
> back to FunctionMockerBase somehow?

I believe it's when the mock object (mock_leveldb_factory in this case) goes out
of scope and is destroyed. If I enter the wrong numerical values they will cause
the test to fail.

[ericu, 2014-06-25 00:09:43]

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
File content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
(right):

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:82:
leveldb::Status open_error_;
On 2014/06/25 00:05:28, cmumford wrote:
> On 2014/06/24 23:57:47, ericu wrote:
> > Initialize open_error_.
> 
> The default constructor for leveldb::Status constructs an OK() object. Do you
> still want to be explicit about this?

Oops--no, nevermind.

https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:101:
EXPECT_CALL(mock_leveldb_factory, DestroyLevelDB(_)).Times(Exactly(1));
On 2014/06/25 00:05:28, cmumford wrote:
> On 2014/06/24 23:57:47, ericu wrote:
> > What causes these expectations to be verified?  I don't see a destructor
that
> > would do it...is there some magic, or are we missing a derivation that leads
> > back to FunctionMockerBase somehow?
> 
> I believe it's when the mock object (mock_leveldb_factory in this case) goes
out
> of scope and is destroyed. If I enter the wrong numerical values they will
cause
> the test to fail.

mock_leveldb_factory is a content::MockLevelDBFactory.  Going up its type chain,
I can't see any destructor that would do that.  Can you show me the call chain
that leads to failure?

[cmumford, 2014-06-25 00:47:06]

On 2014/06/25 00:09:43, ericu wrote:
>
https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
> File content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
> content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:82:
> leveldb::Status open_error_;
> On 2014/06/25 00:05:28, cmumford wrote:
> > On 2014/06/24 23:57:47, ericu wrote:
> > > Initialize open_error_.
> > 
> > The default constructor for leveldb::Status constructs an OK() object. Do
you
> > still want to be explicit about this?
> 
> Oops--no, nevermind.
> 
>
https://codereview.chromium.org/356463008/diff/1/content/browser/indexed_db/i...
> content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc:101:
> EXPECT_CALL(mock_leveldb_factory, DestroyLevelDB(_)).Times(Exactly(1));
> On 2014/06/25 00:05:28, cmumford wrote:
> > On 2014/06/24 23:57:47, ericu wrote:
> > > What causes these expectations to be verified?  I don't see a destructor
> that
> > > would do it...is there some magic, or are we missing a derivation that
leads
> > > back to FunctionMockerBase somehow?
> > 
> > I believe it's when the mock object (mock_leveldb_factory in this case) goes
> out
> > of scope and is destroyed. If I enter the wrong numerical values they will
> cause
> > the test to fail.
> 
> mock_leveldb_factory is a content::MockLevelDBFactory.  Going up its type
chain,
> I can't see any destructor that would do that.  Can you show me the call chain
> that leads to failure?

It looks like the MOCK_METHOD*() macros add a variable into their mock class
which is compatible with either a default or explicit destructor. Here's the
call stack to a failure that I injected.

#1 0x000003072a07 base::debug::(anonymous namespace)::StackDumpSignalHandler()  
        
#2 0x7f1da0558cb0 <unknown>                                                     
        
#3 0x7f1d9ed43425 gsignal                                                       
        
#4 0x7f1d9ed46b8b abort                                                         
        
#5 0x000001e72074
testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectation
sLocked()                                                                       
        
#6 0x000001518e64 testing::internal::FunctionMockerBase<>::~FunctionMockerBase()
        
#7 0x000001518865 testing::internal::FunctionMocker<>::~FunctionMocker()        
        
#8 0x000001518617 content::MockLevelDBFactory::~MockLevelDBFactory()            
        
#9 0x0000009e8522 (anonymous
namespace)::IndexedDBIOErrorTest_CleanUpTest_Test::TestBody(
)                                                                               
        
#10 0x000001eac2f3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
        
#11 0x000001e9969e testing::internal::HandleExceptionsInMethodIfSupported<>()   
        
#12 0x000001e90345 testing::Test::Run()                                         
        
#13 0x000001e90a5b testing::TestInfo::Run()                                     
        
#14 0x000001e9104a testing::TestCase::Run()                                     
        
#15 0x000001e95658 testing::internal::UnitTestImpl::RunAllTests()               
        
#16 0x000001ea5003 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
        
#17 0x000001e9b21e testing::internal::HandleExceptionsInMethodIfSupported<>()   
        
#18 0x000001e952e4 testing::UnitTest::Run()                                     
        
#19 0x000001e21f91 RUN_ALL_TESTS()                                              
        
#20 0x000001e21017 base::TestSuite::Run()                                       
        
#21 0x000001d8c81d content::UnitTestTestSuite::Run()                            
        
#22 0x0000010721f2 base::internal::RunnableAdapter<>::Run()                     
        
#23 0x00000107215c base::internal::InvokeHelper<>::MakeItSo()                   
        
#24 0x00000107210a base::internal::Invoker<>::Run()                             
        
#25 0x0000015bb5de base::Callback<>::Run()                                      
        
#26 0x000001e16a20 base::(anonymous namespace)::LaunchUnitTestsInternal()       
        
#27 0x000001e16717 base::LaunchUnitTests()                                      
        
#28 0x000001071ed0 main                                                         
        
#29 0x7f1d9ed2e76d __libc_start_main                                            
        
#30 0x0000004da5e9 <unknown>

[ericu, 2014-06-25 17:28:36]

lgtm

[cmumford, 2014-06-25 18:36:58]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-25 18:38:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/1

[commit-bot: I haz the power, 2014-06-25 21:14:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-25 21:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 21:21:29]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[cmumford, 2014-06-25 22:14:20]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-25 22:15:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/1

[commit-bot: I haz the power, 2014-06-25 23:24:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-25 23:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 23:30:08]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[cmumford, 2014-06-26 00:15:49]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-26 00:17:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/1

[commit-bot: I haz the power, 2014-06-26 00:51:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-26 00:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 00:54:12]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[cmumford, 2014-06-26 03:19:34]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-26 03:20:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/1

[commit-bot: I haz the power, 2014-06-26 04:40:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-26 04:43:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 04:43:39]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[cmumford, 2014-06-26 14:09:18]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-26 14:10:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/1

[commit-bot: I haz the power, 2014-06-26 14:18:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-26 14:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 14:20:35]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[cmumford, 2014-06-26 17:42:05]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-26 17:43:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/20001

[cmumford, 2014-06-26 19:33:08]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-26 19:33:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/40001

[commit-bot: I haz the power, 2014-06-26 23:28:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-06-26 23:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 23:34:50]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[cmumford, 2014-06-27 13:55:14]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-06-27 13:56:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/40001

[commit-bot: I haz the power, 2014-06-27 14:08:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-06-27 14:17:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-27 14:17:58]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[cmumford, 2014-06-30 15:28:57]

On 2014/06/27 14:17:58, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_aosp on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

ericu@ I've built this CL on Linux/Android/Mac/Windows. From what I can see
these errors are problems with the commit bots. Do you see an error? If not can
you manually push this through for me?

[cmumford, 2014-07-07 16:33:59]

+benm for android_webview/buildbot/deps_whitelist.py
+avi for content/browser/BUILD.gn

[Avi (use Gerrit), 2014-07-07 16:36:55]

lgtm

stamp

assuming that deps is correct

[cmumford, 2014-07-11 16:43:23]

-benm, +torne since Ben is OOO till 7/15

[Torne, 2014-07-14 15:58:09]

Do we really need to add gmock as a dependency of content_browser? That seems
wrong; surely only the tests should require it.

If this is landed we will have to start merging gmock into the android tree to
build WebView and we prefer to keep our dependencies minimal. The WebView build
doesn't build the unit tests, so as long as the dependency is in a test target
it won't matter...

[cmumford, 2014-07-14 18:46:58]

On 2014/07/14 15:58:09, Torne wrote:
> Do we really need to add gmock as a dependency of content_browser? That seems
> wrong; surely only the tests should require it.
> 
> If this is landed we will have to start merging gmock into the android tree to
> build WebView and we prefer to keep our dependencies minimal. The WebView
build
> doesn't build the unit tests, so as long as the dependency is in a test target
> it won't matter...

Thx Torne. You're correct - there was no need for the dependency to be that high
- having content_tests depend on gmock was sufficient. But I still think I need
this change to deps_whitelist.py though for a full build. Am I correct, or is
there a better way to satisfy this dependency for AOSP?

[Torne, 2014-07-14 20:41:06]

On 2014/07/14 18:46:58, cmumford wrote:
> On 2014/07/14 15:58:09, Torne wrote:
> > Do we really need to add gmock as a dependency of content_browser? That
seems
> > wrong; surely only the tests should require it.
> > 
> > If this is landed we will have to start merging gmock into the android tree
to
> > build WebView and we prefer to keep our dependencies minimal. The WebView
> build
> > doesn't build the unit tests, so as long as the dependency is in a test
target
> > it won't matter...
> 
> Thx Torne. You're correct - there was no need for the dependency to be that
high
> - having content_tests depend on gmock was sufficient. But I still think I
need
> this change to deps_whitelist.py though for a full build. Am I correct, or is
> there a better way to satisfy this dependency for AOSP?

There is no "full build" on the AOSP bot; we never build the tests in that
configuration.

[cmumford, 2014-07-14 22:23:27]

On 2014/07/14 20:41:06, Torne wrote:
> On 2014/07/14 18:46:58, cmumford wrote:
> > On 2014/07/14 15:58:09, Torne wrote:
> > > Do we really need to add gmock as a dependency of content_browser? That
> seems
> > > wrong; surely only the tests should require it.
> > > 
> > > If this is landed we will have to start merging gmock into the android
tree
> to
> > > build WebView and we prefer to keep our dependencies minimal. The WebView
> > build
> > > doesn't build the unit tests, so as long as the dependency is in a test
> target
> > > it won't matter...
> > 
> > Thx Torne. You're correct - there was no need for the dependency to be that
> high
> > - having content_tests depend on gmock was sufficient. But I still think I
> need
> > this change to deps_whitelist.py though for a full build. Am I correct, or
is
> > there a better way to satisfy this dependency for AOSP?
> 
> There is no "full build" on the AOSP bot; we never build the tests in that
> configuration.

Thx Torne. I reverted the deps_whitelist.py change and AOSP builds now that
dependency is in a target apparently not build by AOSP.

[cmumford, 2014-07-14 22:23:35]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-14 22:25:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/140001

[commit-bot: I haz the power, 2014-07-14 23:45:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28471)

[commit-bot: I haz the power, 2014-07-15 15:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 15:51:14]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[cmumford, 2014-07-16 00:13:03]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-16 00:17:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/140001

[commit-bot: I haz the power, 2014-07-16 05:50:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-16 06:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 06:00:07]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[cmumford, 2014-07-17 17:39:39]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:41:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/356463008/160001

[commit-bot: I haz the power, 2014-07-18 03:36:15]

Change committed as 283995