Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 356463002: [fsp] Add documentation for the File System Provider API. (Closed)

Created:
6 years, 6 months ago by mtomasz
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Add documentation for the File System Provider API. This patch adds basic documentation, which is mostly auto generated. TEST=Tested manually with a testing server. BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279959

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 11

Patch Set 3 : Addressed comments. #

Total comments: 2

Patch Set 4 : Fixed + removed doc for extensions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M chrome/common/extensions/api/file_system_provider.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/fileSystemProvider.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/fileSystemProvider.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtomasz
@kalman: PTAL. Thanks. Preview: https://chrome-apps-doc.appspot.com/_patch/356463002/apps/fileSystemProvider
6 years, 6 months ago (2014-06-24 04:54:08 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html File chrome/common/extensions/docs/templates/intros/fileSystemProvider.html (right): https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html#newcode21 chrome/common/extensions/docs/templates/intros/fileSystemProvider.html:21: Most obvious use cases are decompressing archives, or accessing ...
6 years, 6 months ago (2014-06-24 14:25:42 UTC) #2
mtomasz
https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html File chrome/common/extensions/docs/templates/intros/fileSystemProvider.html (right): https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html#newcode21 chrome/common/extensions/docs/templates/intros/fileSystemProvider.html:21: Most obvious use cases are decompressing archives, or accessing ...
6 years, 5 months ago (2014-06-25 05:38:14 UTC) #3
not at google - send to devlin
lgtm https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html File chrome/common/extensions/docs/templates/intros/fileSystemProvider.html (right): https://codereview.chromium.org/356463002/diff/20001/chrome/common/extensions/docs/templates/intros/fileSystemProvider.html#newcode40 chrome/common/extensions/docs/templates/intros/fileSystemProvider.html:40: case is decompressing archives. On 2014/06/25 05:38:13, mtomasz ...
6 years, 5 months ago (2014-06-25 14:03:31 UTC) #4
mtomasz
Done. I removed the doc for extensions, since the API is currently not enabled for ...
6 years, 5 months ago (2014-06-26 02:19:43 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-06-26 05:37:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/356463002/60001
6 years, 5 months ago (2014-06-26 05:38:45 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-26 06:25:34 UTC) #8
commit-bot: I haz the power
Change committed as 279959
6 years, 5 months ago (2014-06-26 08:14:25 UTC) #9
not at google - send to devlin
On 2014/06/26 02:19:43, mtomasz wrote: > Done. I removed the doc for extensions, since the ...
6 years, 5 months ago (2014-06-26 14:38:56 UTC) #10
mtomasz
6 years, 5 months ago (2014-06-26 23:00:34 UTC) #11
Message was sent while issue was closed.
On 2014/06/26 14:38:56, kalman wrote:
> On 2014/06/26 02:19:43, mtomasz wrote:
> > Done. I removed the doc for extensions, since the API is currently not
enabled
> > for extensions, but packaged apps only.
> > 
> 
> Oh. I thought the plan was to support this for extensions, what happened?

We can. Let's enable it first, then add a documentation.

Powered by Google App Engine
This is Rietveld 408576698