content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java - Issue 356453003: Don't share renderers between unrelated tabs on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

Issue 356453003: Don't share renderers between unrelated tabs on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address John(me)'s comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

index b9d9f2639b7f50a5b22ecf055309e20ab683cd2f..7686f7ed03fdb5840194adae94f421008788d19a 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

@@ -27,7 +27,7 @@ public class BrowserStartupControllerTest extends InstrumentationTestCase {

private int mInitializedCounter = 0;

@Override

- void prepareToStartBrowserProcess(int numRenderers) throws ProcessInitException {

+ void prepareToStartBrowserProcess(boolean singleProcess) throws ProcessInitException {

if (!mLibraryLoadSucceeds) {

throw new ProcessInitException(

LoaderErrors.LOADER_ERROR_NATIVE_LIBRARY_LOAD_FAILED);

@@ -360,7 +360,7 @@ public class BrowserStartupControllerTest extends InstrumentationTestCase {

@Override

public void run() {

try {

- mController.startBrowserProcessesSync(1);

+ mController.startBrowserProcessesSync(false);

} catch (Exception e) {

fail("Browser should have started successfully");

}

@@ -392,7 +392,7 @@ public class BrowserStartupControllerTest extends InstrumentationTestCase {

// to do both these in a since Runnable instance. This avoids the

// unpredictable race that happens in real situations.

try {

- mController.startBrowserProcessesSync(1);

+ mController.startBrowserProcessesSync(false);

} catch (Exception e) {

fail("Browser should have started successfully");

}

@@ -421,7 +421,7 @@ public class BrowserStartupControllerTest extends InstrumentationTestCase {

@Override

public void run() {

try {

- mController.startBrowserProcessesSync(1);

+ mController.startBrowserProcessesSync(false);

} catch (Exception e) {

fail("Browser should have started successfully");

}