content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java - Issue 356453003: Don't share renderers between unrelated tabs on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 356453003: Don't share renderers between unrelated tabs on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Grace's and John's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

index b285e1922c1e977d9557c624c94e68ef49b923f0..2a4bcd8eb684dde6e498737c202f5dbfd96292b7 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

@@ -92,7 +92,8 @@ public class ChildProcessLauncher {

ChromiumLinkerParams chromiumLinkerParams) {

synchronized (mConnectionLock) {

if (mFreeConnectionIndices.isEmpty()) {

- Log.w(TAG, "Ran out of service.");

+ Log.e(TAG, "Ran out of services to allocate.");

+ assert false;

return null;

}

int slot = mFreeConnectionIndices.remove(0);