Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 356403003: Refactoring canPlayType browsertests to have helper methods (Closed)

Created:
6 years, 5 months ago by amogh.bihani
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring canPlayType browsertests to have helper methods This patch adds helper methods in MediaCanPlayType Tests to avoid repeatition and make test cases better to understand. TEST=content_browsertests --gtest_filter=MediaCanPlayTypeTest* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -620 lines) Patch
M content/browser/media/media_canplaytype_browsertest.cc View 16 chunks +189 lines, -620 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
amogh.bihani
As discussed in the other CL, I have added helper methods for all the test ...
6 years, 5 months ago (2014-06-30 11:11:45 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 5 months ago (2014-06-30 18:59:43 UTC) #2
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 5 months ago (2014-07-01 01:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/356403003/1
6 years, 5 months ago (2014-07-01 01:37:26 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 07:12:09 UTC) #5
Message was sent while issue was closed.
Change committed as 280768

Powered by Google App Engine
This is Rietveld 408576698