Issue 356403002: Waiting for sweeper threads is last resort in SlowAllocateRaw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356403002: Waiting for sweeper threads is last resort in SlowAllocateRaw. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)

Modified:
6 years, 5 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Waiting for sweeper threads is last resort in SlowAllocateRaw. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22090

Patch Set 4 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -16 lines)			Patch
	M	src/spaces.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/spaces.cc	View	1 2 3	3 chunks	+26 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ulan

Better, lgtm https://codereview.chromium.org/356403002/diff/40001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/356403002/diff/40001/src/spaces.cc#newcode2618 src/spaces.cc:2618: if (object != NULL) Nit: it should ...

6 years, 5 months ago (2014-06-30 09:32:48 UTC) #3

Hannes Payer (out of office)

https://codereview.chromium.org/356403002/diff/40001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/356403002/diff/40001/src/spaces.cc#newcode2618 src/spaces.cc:2618: if (object != NULL) On 2014/06/30 09:32:47, ulan wrote: ...

6 years, 5 months ago (2014-06-30 12:38:26 UTC) #4

Hannes Payer (out of office)

6 years, 5 months ago (2014-06-30 12:39:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r22090 (presubmit successful).

Expand Messages | Collapse Messages

Issue 356403002: Waiting for sweeper threads is last resort in SlowAllocateRaw. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages