Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/debug.cc

Issue 356393003: [Arm]: Enable use of extended out-of-line constant pool for Arm. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix issue with inline-constant pool. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2341 matching lines...) Expand 10 before | Expand all | Expand 10 after
2352 } 2352 }
2353 2353
2354 // Move back to where the call instruction sequence started. 2354 // Move back to where the call instruction sequence started.
2355 after_break_target_ = addr - Assembler::kPatchReturnSequenceAddressOffset; 2355 after_break_target_ = addr - Assembler::kPatchReturnSequenceAddressOffset;
2356 } else if (at_debug_break_slot) { 2356 } else if (at_debug_break_slot) {
2357 // Address of where the debug break slot starts. 2357 // Address of where the debug break slot starts.
2358 addr = addr - Assembler::kPatchDebugBreakSlotAddressOffset; 2358 addr = addr - Assembler::kPatchDebugBreakSlotAddressOffset;
2359 2359
2360 // Continue just after the slot. 2360 // Continue just after the slot.
2361 after_break_target_ = addr + Assembler::kDebugBreakSlotLength; 2361 after_break_target_ = addr + Assembler::kDebugBreakSlotLength;
2362 } else if (IsDebugBreak(Assembler::target_address_at(addr, *code))) { 2362 } else {
2363 // We now know that there is still a debug break call at the target address, 2363 addr = Assembler::target_address_from_return_address(frame->pc());
2364 // so the break point is still there and the original code will hold the 2364 if (IsDebugBreak(Assembler::target_address_at(addr, *code))) {
2365 // address to jump to in order to complete the call which is replaced by a 2365 // We now know that there is still a debug break call at the target
2366 // call to DebugBreakXXX. 2366 // address, so the break point is still there and the original code will
2367 // hold the address to jump to in order to complete the call which is
2368 // replaced by a call to DebugBreakXXX.
2367 2369
2368 // Find the corresponding address in the original code. 2370 // Find the corresponding address in the original code.
2369 addr += original_code->instruction_start() - code->instruction_start(); 2371 addr += original_code->instruction_start() - code->instruction_start();
2370 2372
2371 // Install jump to the call address in the original code. This will be the 2373 // Install jump to the call address in the original code. This will be the
2372 // call which was overwritten by the call to DebugBreakXXX. 2374 // call which was overwritten by the call to DebugBreakXXX.
2373 after_break_target_ = Assembler::target_address_at(addr, *original_code); 2375 after_break_target_ = Assembler::target_address_at(addr, *original_code);
2374 } else { 2376 } else {
2375 // There is no longer a break point present. Don't try to look in the 2377 // There is no longer a break point present. Don't try to look in the
2376 // original code as the running code will have the right address. This takes 2378 // original code as the running code will have the right address. This
2377 // care of the case where the last break point is removed from the function 2379 // takes care of the case where the last break point is removed from the
2378 // and therefore no "original code" is available. 2380 // function and therefore no "original code" is available.
2379 after_break_target_ = Assembler::target_address_at(addr, *code); 2381 after_break_target_ = Assembler::target_address_at(addr, *code);
2382 }
2380 } 2383 }
2381 } 2384 }
2382 2385
2383 2386
2384 bool Debug::IsBreakAtReturn(JavaScriptFrame* frame) { 2387 bool Debug::IsBreakAtReturn(JavaScriptFrame* frame) {
2385 HandleScope scope(isolate_); 2388 HandleScope scope(isolate_);
2386 2389
2387 // If there are no break points this cannot be break at return, as 2390 // If there are no break points this cannot be break at return, as
2388 // the debugger statement and stack guard bebug break cannot be at 2391 // the debugger statement and stack guard bebug break cannot be at
2389 // return. 2392 // return.
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
3344 logger_->DebugEvent("Put", message.text()); 3347 logger_->DebugEvent("Put", message.text());
3345 } 3348 }
3346 3349
3347 3350
3348 void LockingCommandMessageQueue::Clear() { 3351 void LockingCommandMessageQueue::Clear() {
3349 LockGuard<Mutex> lock_guard(&mutex_); 3352 LockGuard<Mutex> lock_guard(&mutex_);
3350 queue_.Clear(); 3353 queue_.Clear();
3351 } 3354 }
3352 3355
3353 } } // namespace v8::internal 3356 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698