Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 356383002: Remove flags. (Closed)

Created:
6 years, 5 months ago by John Yoo
Modified:
6 years, 5 months ago
Reviewers:
Rune Fevang, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove command line flags for tweaking suggestions page. BUG=352790 TEST=manually compile (chrome, brower_tests, unit_tests) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281919

Patch Set 1 #

Patch Set 2 : Delete flag in chrome_switches.h #

Patch Set 3 : Add author to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
John Yoo
Hi, I'd like you to review my code. It's first time to upload CL. I ...
6 years, 5 months ago (2014-06-30 06:02:53 UTC) #1
John Yoo
Please review this.
6 years, 5 months ago (2014-07-01 07:08:05 UTC) #2
Rune Fevang
lgtm
6 years, 5 months ago (2014-07-01 17:54:47 UTC) #3
Evan Stade
Hi John, thanks for contributing. Have you gone through the legal steps here[1]? [1] http://dev.chromium.org/developers/contributing-code
6 years, 5 months ago (2014-07-01 22:58:41 UTC) #4
John Yoo
The CQ bit was checked by nearbyh13@gmail.com
6 years, 5 months ago (2014-07-02 01:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nearbyh13@gmail.com/356383002/20001
6 years, 5 months ago (2014-07-02 01:58:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 01:58:36 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-02 01:58:37 UTC) #8
John Yoo
I just have signed "Google Individual Contributor License Agreement" on the "https://developers.google.com/open-source/cla/individual?csw=1" site.
6 years, 5 months ago (2014-07-02 02:14:13 UTC) #9
John Yoo
On 2014/07/01 22:58:41, Evan Stade wrote: > Hi John, > > thanks for contributing. Have ...
6 years, 5 months ago (2014-07-02 05:09:23 UTC) #10
John Yoo
On 2014/07/02 01:58:35, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 5 months ago (2014-07-03 00:38:59 UTC) #11
John Yoo
Hi Evan Could you review again ? Thanks
6 years, 5 months ago (2014-07-04 05:20:06 UTC) #12
Evan Stade
On 2014/07/04 05:20:06, nearbyh13 wrote: > Hi Evan > > Could you review again ? ...
6 years, 5 months ago (2014-07-07 15:22:07 UTC) #13
John Yoo
On 2014/07/07 15:22:07, Evan Stade wrote: > On 2014/07/04 05:20:06, nearbyh13 wrote: > > Hi ...
6 years, 5 months ago (2014-07-08 02:07:23 UTC) #14
Evan Stade
lgtm, thanks.
6 years, 5 months ago (2014-07-08 18:01:02 UTC) #15
John Yoo
The CQ bit was checked by nearbyh13@gmail.com
6 years, 5 months ago (2014-07-09 00:16:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nearbyh13@gmail.com/356383002/40001
6 years, 5 months ago (2014-07-09 00:18:43 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:13:30 UTC) #18
Message was sent while issue was closed.
Change committed as 281919

Powered by Google App Engine
This is Rietveld 408576698