Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 356353002: Reenable X11TopmostWindowFinderTests (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Elliot Glaysher, erg
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reenable X11TopmostWindowFinderTests BUG=388241 TEST=None TBR=erg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282567

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -402 lines) Patch
M chrome/chrome_tests.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
A + ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc View 6 chunks +16 lines, -8 lines 0 comments Download
D ui/views/widget/desktop_aura/x11_topmost_window_finder_unittest.cc View 1 chunk +0 lines, -393 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
Elliot, can you please take a look? The success of X11TopmostWindowFinderTests relies on the x ...
6 years, 5 months ago (2014-07-05 15:41:41 UTC) #1
erg
worth a shot. lgtm.
6 years, 5 months ago (2014-07-10 20:27:58 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-10 21:18:18 UTC) #3
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-10 21:18:29 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-10 21:18:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/356353002/20001
6 years, 5 months ago (2014-07-10 21:20:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 23:47:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 00:07:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/46543)
6 years, 5 months ago (2014-07-11 00:07:44 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-11 00:34:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/356353002/60001
6 years, 5 months ago (2014-07-11 00:37:23 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 07:04:53 UTC) #12
Message was sent while issue was closed.
Change committed as 282567

Powered by Google App Engine
This is Rietveld 408576698