Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: chrome/chrome_browser.gypi

Issue 356303002: First pass on adding a chrome/browser GN target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/secondary/tools/grit/grit_rule.gni ('K') | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index f1f61bf3e6c69cdc31e6c7189ea0c93b88e3c761..6fbf050412ecb7627d583326149eb2077eb5ee30 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -702,8 +702,6 @@
'browser/local_discovery/privet_http.h',
'browser/local_discovery/privet_http_asynchronous_factory_mac.cc',
'browser/local_discovery/privet_http_asynchronous_factory_mac.h',
- 'browser/local_discovery/privet_local_printer_lister.h',
tfarina 2014/06/29 19:51:10 why did you remove these?
brettw 2014/06/30 18:10:01 It's in another list already.
- 'browser/local_discovery/privet_local_printer_lister.cc',
'browser/local_discovery/privet_url_fetcher.cc',
'browser/local_discovery/privet_url_fetcher.h',
'browser/local_discovery/privetv3_crypto_provider.cc',
@@ -1671,15 +1669,6 @@
'browser/webdata/web_data_service_win.cc',
'browser/webdata/web_intents_table.cc',
'browser/webdata/web_intents_table.h',
-
- # These files are generated by GRIT.
- '<(grit_out_dir)/grit/component_extension_resources_map.cc',
tfarina 2014/06/29 19:51:10 I do not know why you make this change.
brettw 2014/06/30 18:10:01 I don't want these GYP variables to appear in the
- '<(grit_out_dir)/grit/theme_resources_map.cc',
- '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/grit/ui_resources_map.cc',
-
- # This file is generated by
- # chrome/browser/metrics/variations/generate_resources_map.py
- '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',
],
'chrome_browser_mac_sources': [
'browser/media_galleries/fileapi/iphoto_data_provider.cc',
@@ -2987,6 +2976,15 @@
],
'sources': [
'<@(chrome_browser_non_ios_sources)',
+
+ # These files are generated by GRIT.
+ '<(grit_out_dir)/grit/component_extension_resources_map.cc',
+ '<(grit_out_dir)/grit/theme_resources_map.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/grit/ui_resources_map.cc',
+
+ # This file is generated by
+ # chrome/browser/metrics/variations/generate_resources_map.py
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',
],
'defines': [
'<@(nacl_defines)',
« build/secondary/tools/grit/grit_rule.gni ('K') | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698