Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3578)

Unified Diff: Tools/GardeningServer/scripts/controllers.js

Issue 356273002: Remove StatusArea code from GOM it's dead. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/controllers.js
diff --git a/Tools/GardeningServer/scripts/controllers.js b/Tools/GardeningServer/scripts/controllers.js
index 8cfb7feae8fdd4145d207283a95d4077e79a1b0e..0ab87ec96bd28433caf7082178172120fd561e57 100644
--- a/Tools/GardeningServer/scripts/controllers.js
+++ b/Tools/GardeningServer/scripts/controllers.js
@@ -37,17 +37,6 @@ function isAnyReftest(testName, resultsByTest)
});
}
-// FIXME: Where should this function go?
-function updateExpectationsWithStatusUpdates(failureInfoList)
-{
- var statusView = new ui.StatusArea('Expectations Update');
- var id = statusView.newId();
-
- var testNames = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
- var testName = testNames.length == 1 ? testNames[0] : testNames.length + ' tests';
- statusView.addMessage(id, 'Updating expectations of ' + testName + '...');
-}
-
controllers.ResultsDetails = base.extends(Object, {
init: function(view, resultsByTest)
{
@@ -59,7 +48,6 @@ controllers.ResultsDetails = base.extends(Object, {
$(this._view).bind('next', this.onNext.bind(this));
$(this._view).bind('previous', this.onPrevious.bind(this));
- $(this._view).bind('expectfailure', this.onUpdateExpectations.bind(this));
},
onNext: function()
{
@@ -76,10 +64,6 @@ controllers.ResultsDetails = base.extends(Object, {
return results.failureInfoForTestAndBuilder(this._resultsByTest, testName, builderName);
}.bind(this));
},
- onUpdateExpectations: function()
- {
- updateExpectationsWithStatusUpdates(this._failureInfoList());
- }
});
var FailureStreamController = base.extends(Object, {
@@ -104,9 +88,6 @@ var FailureStreamController = base.extends(Object, {
$(failure).bind('examine', function() {
this.onExamine(failure);
}.bind(this));
- $(failure).bind('expectfailure', function() {
- this.onUpdateExpectations(failure);
- }.bind(this));
}
failure.addFailureAnalysis(failureAnalysis);
this._testFailures.update(key, failure);
@@ -140,10 +121,6 @@ var FailureStreamController = base.extends(Object, {
{
return base.flattenArray(failures.testNameList().map(model.unexpectedFailureInfoForTestName));
},
- onUpdateExpectations: function(failures)
- {
- updateExpectationsWithStatusUpdates(this._toFailureInfoList(failures));
- }
});
controllers.UnexpectedFailures = base.extends(FailureStreamController, {
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698