Move HomeCard to avoid virtual keyboard when it's shown.

Move HomeCard to avoid virtual keyboard when it's shown.

BUG=386652
R=sadrul@chromium.org, oshima@chromium.org
TBR=kevers@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282081

[sadrul, 2014-07-01 05:45:06]

I seem to remember the way things like this is done (or is planned to be done)
is to change the 'working area' of the display when the virtual keyboard shows
up, and the widgets are repositioned from the 'work area changed' callback.
+kevers@ and +oshima@ to advise if similar approach would be more useful here
too.

[Jun Mukai, 2014-07-01 19:45:13]

On 2014/07/01 05:45:06, sadrul wrote:
> I seem to remember the way things like this is done (or is planned to be done)
> is to change the 'working area' of the display when the virtual keyboard shows
> up, and the widgets are repositioned from the 'work area changed' callback.
> +kevers@ and +oshima@ to advise if similar approach would be more useful here
> too.

I am afraid that work area isn't applied here.  The virtual keyboard shouldn't
affect the display's work area, because it should not resize normal browser
windows and athena activities. Instead, the virtual keyboard lays over the
current workspace, and that's why keyboard_controller_observer exists.

I think some components in Ash is doing similar thing as well. See
ash/wm/app_list_controller.h
for example.

Also I didn't make home_card_impl inherit keyboard_controller_observer directly
just because I don't want to introduce the dependency from home_card to content/

[oshima, 2014-07-08 17:49:50]

On 2014/07/01 19:45:13, Jun Mukai wrote:
> On 2014/07/01 05:45:06, sadrul wrote:
> > I seem to remember the way things like this is done (or is planned to be
done)
> > is to change the 'working area' of the display when the virtual keyboard
shows
> > up, and the widgets are repositioned from the 'work area changed' callback.
> > +kevers@ and +oshima@ to advise if similar approach would be more useful
here
> > too.
> 

That was a short term workaround, which had issues like the one mukai-san
explained below. It's been changed not to use work area a while ago.

> I am afraid that work area isn't applied here.  The virtual keyboard shouldn't
> affect the display's work area, because it should not resize normal browser
> windows and athena activities. Instead, the virtual keyboard lays over the
> current workspace, and that's why keyboard_controller_observer exists.
> 
> I think some components in Ash is doing similar thing as well. See
> ash/wm/app_list_controller.h
> for example.
> 
> Also I didn't make home_card_impl inherit keyboard_controller_observer
directly
> just because I don't want to introduce the dependency from home_card to
content/

[oshima, 2014-07-08 18:31:29]

lgtm with nit and one request.

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:40: // change to appropriate modules of athena.
can you add

// TODO(oshima): move the VK bounds logic to screen manager

? I think this should be a part of the screen's service as we need similar
behavior for dialog/contents.

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:54: }
DISALLOW_COPY_AND_ASSIGN

[Jun Mukai, 2014-07-08 22:25:41]

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:40: // change to appropriate modules of athena.
On 2014/07/08 18:31:29, oshima wrote:
> can you add
> 
> // TODO(oshima): move the VK bounds logic to screen manager
> 
> ? I think this should be a part of the screen's service as we need similar
> behavior for dialog/contents.

Done.

https://codereview.chromium.org/356263003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:54: }
On 2014/07/08 18:31:29, oshima wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[Jun Mukai, 2014-07-08 22:25:45]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-08 22:27:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/356263003/20001

[commit-bot: I haz the power, 2014-07-09 01:53:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-07-09 01:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 01:57:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Jun Mukai, 2014-07-09 17:51:18]

On 2014/07/09 01:57:39, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

let me submit with TBR=kevers, for adding ui/keyboard to athena/main/DEPS

[Jun Mukai, 2014-07-09 17:51:23]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-09 17:52:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/356263003/20001

[commit-bot: I haz the power, 2014-07-09 17:57:28]

Change committed as 282081

[kevers, 2014-07-09 20:13:55]

lgtm