components/autofill/core/common/save_password_progress_logger_unittest.cc - Issue 356223002: PasswordForm: move from current/old password scheme to current/new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger_unittest.cc

Issue 356223002: PasswordForm: move from current/old password scheme to current/new. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix problems with discrepancies between |observed_form_| and |form|, and revert former to constref. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger_unittest.cc

diff --git a/components/autofill/core/common/save_password_progress_logger_unittest.cc b/components/autofill/core/common/save_password_progress_logger_unittest.cc

index 805cc5f9c6a39d49ff20d723f5a1b1b238342b6c..bb5f4d085a96e8bca20108f83debbb43feab5a0a 100644

--- a/components/autofill/core/common/save_password_progress_logger_unittest.cc

+++ b/components/autofill/core/common/save_password_progress_logger_unittest.cc

@@ -69,7 +69,7 @@ TEST(SavePasswordProgressLoggerTest, LogPasswordFormElementID) {

const std::string kSpecialCharsInsideExpected("x a b c d e x");

form.username_element = UTF8ToUTF16(kHTMLInside);

form.password_element = UTF8ToUTF16(kIPAddressInside);

- form.old_password_element = UTF8ToUTF16(kSpecialCharsInside);

+ form.new_password_element = UTF8ToUTF16(kSpecialCharsInside);

logger.LogPasswordForm(SavePasswordProgressLogger::STRING_MESSAGE, form);

SCOPED_TRACE(testing::Message() << "Log string = ["

<< logger.accumulated_log() << "]");