components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc - Issue 356223002: PasswordForm: move from current/old password scheme to current/new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 356223002: PasswordForm: move from current/old password scheme to current/new. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix problems with discrepancies between |observed_form_| and |form|, and revert former to constref. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/autofill/core/common/password_form.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

index a56986eb218e78c32f7e4fa4fd954307a2282da8..c38ff86a3fbdba7b71be36986466b9fef49efa81 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

@@ -163,11 +163,12 @@ TEST_F(PasswordFormConversionUtilsTest,

EXPECT_EQ(GURL(kTestFormActionURL), password_form->action);

EXPECT_EQ(base::UTF8ToUTF16("username1"), password_form->username_element);

EXPECT_EQ(base::UTF8ToUTF16("John"), password_form->username_value);

- EXPECT_EQ(base::UTF8ToUTF16("password2"), password_form->password_element);

- EXPECT_EQ(base::UTF8ToUTF16("secret"), password_form->password_value);

EXPECT_EQ(base::UTF8ToUTF16("password1"),

- password_form->old_password_element);

- EXPECT_EQ(base::UTF8ToUTF16("oldsecret"), password_form->old_password_value);

+ password_form->password_element);

+ EXPECT_EQ(base::UTF8ToUTF16("oldsecret"), password_form->password_value);

+ EXPECT_EQ(base::UTF8ToUTF16("password2"),

+ password_form->new_password_element);

+ EXPECT_EQ(base::UTF8ToUTF16("secret"), password_form->new_password_value);

ASSERT_EQ(2u, password_form->other_possible_usernames.size());

EXPECT_EQ(base::UTF8ToUTF16("William"),

password_form->other_possible_usernames[0]);