PasswordForm: move from current/old password scheme to current/new.

components/password_manager/core/browser/password_form_manager.h

Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 80712d68b3dc279f1480fb1effc93a50a3d21dc3..c42525dece28e9a453556e794c759e042527ce4b 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -122,7 +122,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // treat a possible usernames match as a sign that our original heuristics
   // were wrong and that the user selected the correct username from the
   // Autofill UI.
-  void ProvisionallySave(const autofill::PasswordForm& credentials,
+  void ProvisionallySave(autofill::PasswordForm credentials,

[vabr (Chromium), 2014/06/30 10:07:20]

nit: It looks like ProvisionallySave is already called on a form locally created
just for it. To avoid another copy, please make |credentials| a non-const
PasswordForm* argument, and modify it directly, documenting the possible
modification in the comment.

[Ilya Sherman, 2014/07/01 03:08:47]

FWIW, I agree that we shouldn't pass this parameter by value -- that's just very
unusual in Chrome code, for objects of nontrivial size.  I personally think it
would be most appropriate to pass a const-ref into the function, and then make a
local copy within it; but passing a pointer is fine as well.  The difference is
in terms of whether the modifications are purely an implementation detail, or
visible to an external caller.

[engedy, 2014/07/03 13:34:19]

I have reverted this, because it is no longer needed to modify the argument in
the new design.

                          OtherPossibleUsernamesAction action);
 
   // Handles save-as-new or update of the form managed by this manager.