PasswordForm: move from current/old password scheme to current/new.

components/autofill/core/common/password_form.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 98 matching lines @@
   // has implemented some form of autofill.
   base::string16 username_value;
 
   // This member is populated in cases where we there are multiple input
   // elements that could possibly be the username. Used when our heuristics for
   // determining the username are incorrect. Optional.
   //
   // When parsing an HTML form, this is typically empty.
   std::vector<base::string16> other_possible_usernames;
 
-  // The name of the password input element, Optional (improves scoring).
+  // The name of the input element corresponding to the current password.
+  // Optional (improves scoring).
   //
-  // When parsing an HTML form, this must always be set.
+  // When parsing an HTML form, this must always be set, unless it is a sign-up
+  // form or a change password form that does not ask for the current password.
+  // In these two cases the |new_password_element| will always be set.
   base::string16 password_element;
 
-  // The password. Required.
+  // The current password. Required.

[Ilya Sherman, 2014/07/01 03:08:47]

In what sense is this field required, if the one above is optional?

[engedy, 2014/07/03 13:34:19]

Tried to clarify, but I am not sure myself.

@Vaclav, WDYT?

[vabr (Chromium), 2014/07/03 14:42:56]

According to the comments, the password_value is "required" but "typically
empty". :)
Since it is an aggregated data member, it's always there. So either the
"requirement" is trivial ("always have the whole object of PasswordForm, not
just a chunk of it"), or it means "non-empty", and then it contradicts the
comment below.

[engedy, 2014/07/03 18:47:36]

I have rephrased.

   //
   // When parsing an HTML form, this is typically empty.
   base::string16 password_value;
 
   // False if autocomplete is set to "off" for the password input element;
   // True otherwise.
   bool password_autocomplete_set;
 
-  // If the form was a change password form, the name of the
-  // 'old password' input element. Optional.
-  base::string16 old_password_element;
+  // If the form was a sign-up or a change password form, the name of the input
+  // element corresponding to the new password. Optional.
+  base::string16 new_password_element;
 
-  // The old password. Optional.
-  base::string16 old_password_value;
+  // The new password. Optional.
+  base::string16 new_password_value;
 
   // Whether or not this login was saved under an HTTPS session with a valid
   // SSL cert. We will never match or autofill a PasswordForm where
   // ssl_valid == true with a PasswordForm where ssl_valid == false. This means
   // passwords saved under HTTPS will never get autofilled onto an HTTP page.
   // When importing, this should be set to true if the page URL is HTTPS, thus
   // giving it "the benefit of the doubt" that the SSL cert was valid when it
   // was saved. Default to false.
   bool ssl_valid;
 
@@ skipping 67 matching lines @@
 // Map username to PasswordForm* for convenience. See password_form_manager.h.
 typedef std::map<base::string16, PasswordForm*> PasswordFormMap;
 
 // For testing.
 std::ostream& operator<<(std::ostream& os,
                          const autofill::PasswordForm& form);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__