Issue 356173002: Get rid of redundant functions Editor::indent and outdent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356173002: Get rid of redundant functions Editor::indent and outdent (Closed)

Created:
6 years, 5 months ago by yosin_UTC9

Modified:
6 years, 5 months ago

Reviewers:
eseidel

CC:
blink-reviews, groby+blinkspell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Get rid of redundant functions Editor::indent and outdent This patch removes redundant functions Editor::indent() and outdent(), which were used for special handling of WebFrame::executeCommand. Editor::indent/outdent are identical to executeIndent/executeOutend. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177073

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -18 lines)			Patch
M	Source/core/editing/Editor.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

Could you review this patch? Thanks in advance. Note: Special handling of "Indent" and "Outdent" ...

6 years, 5 months ago (2014-06-27 05:08:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/356173002/1

6 years, 5 months ago (2014-06-27 05:26:30 UTC) #3

Message was sent while issue was closed.

Change committed as 177073

Expand Messages | Collapse Messages