Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(210)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
356133005
: X87: Use IC register definitions in platform files. (Closed)
Created:
6 years, 5 months ago by
chunyang.dai
Modified:
6 years, 5 months ago
Reviewers:
Weiliang
,
mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.
More Reviews
Description
X87: Use IC register definitions in platform files. port r22035 original commit message: Use IC register definitions in platform files. BUG=
Patch Set 1
#
Created:
6 years, 5 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+118 lines, -138 lines
)
Patch
M
src/x87/code-stubs-x87.cc
View
1 chunk
+0 lines, -28 lines
0 comments
Download
M
src/x87/debug-x87.cc
View
2 chunks
+6 lines, -10 lines
0 comments
Download
M
src/x87/full-codegen-x87.cc
View
12 chunks
+39 lines, -27 lines
0 comments
Download
M
src/x87/ic-x87.cc
View
10 chunks
+60 lines, -63 lines
0 comments
Download
M
src/x87/lithium-codegen-x87.cc
View
3 chunks
+6 lines, -6 lines
0 comments
Download
M
src/x87/lithium-x87.cc
View
3 chunks
+5 lines, -4 lines
0 comments
Download
M
src/x87/stub-cache-x87.cc
View
1 chunk
+2 lines, -0 lines
0 comments
Download
Messages
Total messages: 3 (0 generated)
Expand Messages
|
Collapse Messages
chunyang.dai
weiliang. please review this porting patch. thanks,
6 years, 5 months ago (2014-06-27 02:33:12 UTC)
#1
weiliang. please review this porting patch. thanks,
Weiliang
lgtm
6 years, 5 months ago (2014-06-27 03:22:29 UTC)
#2
lgtm
Weiliang
Committed as r22047
6 years, 5 months ago (2014-06-27 03:24:46 UTC)
#3
Committed as r22047
Expand Messages
|
Collapse Messages
Issue 356133005: X87: Use IC register definitions in platform files. (Closed)
Created 6 years, 5 months ago by chunyang.dai
Modified 6 years, 5 months ago
Reviewers: Weiliang, mvstanton
Base URL: https://github.com/v8/v8.git@master
Comments: 0
This is Rietveld
408576698