Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 356133003: Update the two remaining tests for the fast text autosizer (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 6 months ago
Reviewers:
skobes
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Update the two remaining tests for the fast text autosizer This patch updates the two remaining tests from the old text autosizer for the new fast text autosizer. cluster-list-item.html has been modified to not show the list bullets and a comment has been added about why. oscillation-javascript-fontsize-change.html has been updated to not be a shrink-wrapped div. This changes the test significantly but I think the test coverage may still be worth it. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/text-autosizing/cluster-list-item.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/text-autosizing/cluster-list-item-expected.html View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/text-autosizing/oscillation-javascript-fontsize-change.html View 2 chunks +9 lines, -19 lines 0 comments Download
M LayoutTests/fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pdr.
6 years, 6 months ago (2014-06-26 23:22:01 UTC) #1
skobes
lgtm
6 years, 6 months ago (2014-06-26 23:24:40 UTC) #2
pdr.
On 2014/06/26 23:24:40, skobes wrote: > lgtm I got my 8th nag email from ojan ...
6 years, 6 months ago (2014-06-26 23:27:57 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-26 23:28:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/356133003/1
6 years, 6 months ago (2014-06-26 23:29:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-27 00:57:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-27 01:01:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/1886)
6 years, 6 months ago (2014-06-27 01:01:58 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-27 02:39:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/356133003/1
6 years, 6 months ago (2014-06-27 02:40:09 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 02:49:10 UTC) #11
Message was sent while issue was closed.
Change committed as 177047

Powered by Google App Engine
This is Rietveld 408576698