Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 356123004: Remove wrong commented out code from RenderLayer::updateLayerPositionsAfterScroll (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, eseidel, Julien - ping for review
Project:
blink
Visibility:
Public.

Description

Remove wrong commented out code from RenderLayer::updateLayerPositionsAfterScroll This comment is about ASSERTing the consistency of state that no long exists. Also, remove m_canSkipRepaintRectsUpdateOnScroll because it's just renderer()->isTableCell(). R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M Source/core/rendering/RenderLayer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-06-27 18:10:32 UTC) #1
esprehn
On 2014/06/27 18:10:32, abarth wrote: This lgtm, but I wonder why table cells are special.
6 years, 5 months ago (2014-06-27 18:11:52 UTC) #2
abarth-chromium
On 2014/06/27 at 18:11:52, esprehn wrote: > On 2014/06/27 18:10:32, abarth wrote: > > This ...
6 years, 5 months ago (2014-06-27 18:47:33 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-06-27 20:12:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/356123004/1
6 years, 5 months ago (2014-06-27 20:12:47 UTC) #5
abarth-chromium
6 years, 5 months ago (2014-06-27 20:34:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r177129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698