Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 356103003: Use IDL default argument value for Range.collapse()'s toStart argument (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use IDL default argument value for Range.collapse()'s toStart argument Replace the existing [Default=Undefined] extended attribute, which since undefined coerces to false means the same thing, with the actual default value that's in the specification. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/dom/Range.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Jens Widell
PTAL
6 years, 5 months ago (2014-06-30 11:33:15 UTC) #1
Jens Widell
On 2014/06/30 11:33:15, Jens Lindström wrote: > PTAL haraken@: I think I published CL this ...
6 years, 5 months ago (2014-06-30 15:25:09 UTC) #2
haraken
LGTM
6 years, 5 months ago (2014-06-30 15:26:53 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-30 15:28:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/356103003/1
6 years, 5 months ago (2014-06-30 15:29:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-30 16:33:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 17:37:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/14367)
6 years, 5 months ago (2014-06-30 17:37:31 UTC) #8
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-30 17:45:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/356103003/1
6 years, 5 months ago (2014-06-30 17:45:49 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 18:52:50 UTC) #11
Message was sent while issue was closed.
Change committed as 177235

Powered by Google App Engine
This is Rietveld 408576698