Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 356083002: [Ozone] Add Ozone EGL demo (Closed)

Created:
6 years, 6 months ago by dnicoara
Modified:
6 years, 5 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Ozone] Add Ozone EGL demo BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281317

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 8

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -14 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + ui/ozone/demo/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/ozone/demo/egl_demo.cc View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A + ui/ozone/demo/ozone_demos.gyp View 1 chunk +9 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 2 1 chunk +10 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vignatti (out of this project)
this demo is very useful! You should sent for review to be integrated dnicoara@ :)
6 years, 5 months ago (2014-06-30 13:52:25 UTC) #1
dnicoara
PTAL
6 years, 5 months ago (2014-07-03 17:28:56 UTC) #2
spang
https://codereview.chromium.org/356083002/diff/40001/ui/ozone/demo/egl_demo.cc File ui/ozone/demo/egl_demo.cc (right): https://codereview.chromium.org/356083002/diff/40001/ui/ozone/demo/egl_demo.cc#newcode27 ui/ozone/demo/egl_demo.cc:27: gfx::GLSurface::CreateViewGLSurface(widget); this can fail. https://codereview.chromium.org/356083002/diff/40001/ui/ozone/demo/egl_demo.cc#newcode29 ui/ozone/demo/egl_demo.cc:29: NULL, surface.get(), gfx::PreferIntegratedGpu); ...
6 years, 5 months ago (2014-07-03 18:33:23 UTC) #3
dnicoara
https://codereview.chromium.org/356083002/diff/40001/ui/ozone/demo/egl_demo.cc File ui/ozone/demo/egl_demo.cc (right): https://codereview.chromium.org/356083002/diff/40001/ui/ozone/demo/egl_demo.cc#newcode27 ui/ozone/demo/egl_demo.cc:27: gfx::GLSurface::CreateViewGLSurface(widget); On 2014/07/03 18:33:23, spang wrote: > this can ...
6 years, 5 months ago (2014-07-03 18:51:37 UTC) #4
spang
lgtm
6 years, 5 months ago (2014-07-03 19:24:20 UTC) #5
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 5 months ago (2014-07-03 20:12:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/356083002/80001
6 years, 5 months ago (2014-07-03 20:14:22 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 20:15:33 UTC) #8
Message was sent while issue was closed. 
Change committed as 281317

Powered by Google App Engine
This is Rietveld 408576698