Issue 356053004: Pepper: Remove PPP_ManifestService.

Issue 356053004: Pepper: Remove PPP_ManifestService. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
bbudge

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Remove PPP_ManifestService. Now that enough logic has been moved out of the trusted plugin, we can get rid of PPP_ManifestService and make the code in the Non-SFI case much clearer. CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32 BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280204

Patch Set 1 : rebased #

Total comments: 1

Patch Set 2 : fix declaration order #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -169 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	1	4 chunks	+23 lines, -37 lines	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View		2 chunks	+0 lines, -17 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View		4 chunks	+14 lines, -43 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		3 chunks	+0 lines, -59 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View		2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bbudge

Wow LGTM https://codereview.chromium.org/356053004/diff/20001/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/356053004/diff/20001/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode187 components/nacl/renderer/ppb_nacl_private_impl.cc:187: bool uses_nonsfi_mode; nit: seems out of order.

6 years, 6 months ago (2014-06-26 21:54:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/356053004/40001

6 years, 6 months ago (2014-06-26 22:14:04 UTC) #4

Message was sent while issue was closed.

Change committed as 280204

Expand Messages | Collapse Messages