Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 356043002: Declare 20 renderer services on Android. (Closed)

Created:
6 years, 5 months ago by ppi
Modified:
6 years, 5 months ago
Reviewers:
Yaron, klobag.chromium
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Declare 20 renderer services on Android. On Android the OS manages Chrome's renderers on the system process list, killing them under memory pressure and (as per KitKat) allowing a hard maximum of 8 renderers in background. As we're going to stop limiting the number of process hosts (and sharing renderers among unrelated tabs) on Android, we want to have more renderer services declared so that we don't run out of them when the OS is particularly generous. According to UMA, we're at the current limit at 1% of page loads. This patch declares additional renderer services on Android, totalling 20 with the patch. After the embedders update, we will raise the actual limit in ChildProcessLauncher in the next patch. BUG=325842 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281324

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Move raising the limit to a separate patch (going the 3-way patch way). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -14 lines) Patch
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService13.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService14.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService15.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService16.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService17.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService18.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/app/SandboxedProcessService19.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +35 lines, -0 lines 0 comments Download
M content/shell/android/linker_test_apk/AndroidManifest.xml View 1 chunk +35 lines, -0 lines 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ppi
6 years, 5 months ago (2014-06-26 14:00:03 UTC) #1
nasko
If we are adjusting, might as well adjust it to have a comfortable margin. Based ...
6 years, 5 months ago (2014-06-26 16:51:44 UTC) #2
klobag.chromium
lgtm 20 is already a lot. Declare the service doesn't mean the platform will keep ...
6 years, 5 months ago (2014-06-28 01:44:35 UTC) #3
ppi
+Yaron for OWNER look.
6 years, 5 months ago (2014-07-01 10:48:44 UTC) #4
Yaron
lgtm (of course you'll need an internal change too)
6 years, 5 months ago (2014-07-01 16:34:48 UTC) #5
ppi
Thanks! Yup. I think it would make sense to do a 3-way patch here - ...
6 years, 5 months ago (2014-07-03 12:54:21 UTC) #6
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 5 months ago (2014-07-03 12:54:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/356043002/40001
6 years, 5 months ago (2014-07-03 12:55:24 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 21:11:13 UTC) #9
Message was sent while issue was closed.
Change committed as 281324

Powered by Google App Engine
This is Rietveld 408576698