Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 356013002: Add an assert that TracedValue builder closes only most recently opened container (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add an assert that TracedValue builder closes only most recently opened container When an array or a dictionary is ended we check that there are no other open containers on top of it. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177095

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/TracedValue.h View 1 5 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yurys
6 years, 6 months ago (2014-06-26 11:21:38 UTC) #1
caseq
lgtm
6 years, 6 months ago (2014-06-26 11:34:25 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-06-27 10:38:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/356013002/20001
6 years, 5 months ago (2014-06-27 10:38:48 UTC) #4
yurys
@pfeldman: please do OWNERS review
6 years, 5 months ago (2014-06-27 10:42:49 UTC) #5
pfeldman
lgtm
6 years, 5 months ago (2014-06-27 10:56:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-06-27 11:43:34 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 12:21:54 UTC) #8
Message was sent while issue was closed.
Change committed as 177095

Powered by Google App Engine
This is Rietveld 408576698