Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 355973002: Unloaded web fonts should not report Resource Timing (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 5 months ago
Reviewers:
Nate Chapin, bashi
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org, bashi
Project:
blink
Visibility:
Public.

Description

Unloaded web fonts should not report Resource Timing ResourceFetcher::requestLoadStarted() should not report Resource Timing when the resource is not started loading. BUG=389038 TEST=fast/css/resource-timing-for-unloaded-font.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177386

Patch Set 1 #

Patch Set 2 : Fix cache-hit-resource-timing-buffer-full-crash.html on mac #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
A LayoutTests/fast/css/resource-timing-for-unloaded-font.html View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/resource-timing-for-unloaded-font-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-06-27 01:16:39 UTC) #1
bashi
just being nagging... https://codereview.chromium.org/355973002/diff/20001/LayoutTests/fast/css/resource-timing-for-unloaded-font.html File LayoutTests/fast/css/resource-timing-for-unloaded-font.html (right): https://codereview.chromium.org/355973002/diff/20001/LayoutTests/fast/css/resource-timing-for-unloaded-font.html#newcode6 LayoutTests/fast/css/resource-timing-for-unloaded-font.html:6: src: url(file:///foo.ttf); nit: it would be ...
6 years, 6 months ago (2014-06-27 01:40:51 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/355973002/diff/20001/LayoutTests/fast/css/resource-timing-for-unloaded-font.html File LayoutTests/fast/css/resource-timing-for-unloaded-font.html (right): https://codereview.chromium.org/355973002/diff/20001/LayoutTests/fast/css/resource-timing-for-unloaded-font.html#newcode6 LayoutTests/fast/css/resource-timing-for-unloaded-font.html:6: src: url(file:///foo.ttf); On 2014/06/27 01:40:51, bashi1 wrote: > nit: ...
6 years, 6 months ago (2014-06-27 02:14:57 UTC) #3
Nate Chapin
Ok. LGTM
6 years, 5 months ago (2014-07-01 19:10:23 UTC) #4
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 5 months ago (2014-07-02 11:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/355973002/40001
6 years, 5 months ago (2014-07-02 11:56:20 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:35:56 UTC) #7
Message was sent while issue was closed. 
Change committed as 177386

Powered by Google App Engine
This is Rietveld 408576698